Frank Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44169 )
Change subject: mb/google/volteer/halvor: Enable card reader function on Halvor
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/44169/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/44169/1//COMMIT_MSG@7
PS1, Line 7: mb/google/volteer/halvor: Enable cardreader function on Halvor
card reader
Done
https://review.coreboot.org/c/coreboot/+/44169/1/src/mainboard/google/voltee...
File src/mainboard/google/volteer/variants/halvor/gpio.c:
https://review.coreboot.org/c/coreboot/+/44169/1/src/mainboard/google/voltee...
PS1, Line 196: PAD_CFG_GPO(GPP_D16, 1, DEEP),
Do we need this in early table?
Here is the reference.
https://review.coreboot.org/c/coreboot/+/43988
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44169
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I51752f47bc8d31d3a11da728ce00ca754381fde9
Gerrit-Change-Number: 44169
Gerrit-PatchSet: 2
Gerrit-Owner: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Amanda Hwang
amanda_hwang@compal.corp-partner.google.com
Gerrit-Comment-Date: Tue, 04 Aug 2020 10:08:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-MessageType: comment