Attention is currently required from: Angel Pons, Arthur Heymans, Elyes Haouas, Felix Held.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69339 )
Change subject: Revert "mb/aopen/dxplplusu: Remove board" ......................................................................
Patch Set 2:
(18 comments)
File src/mainboard/aopen/dxplplusu/acpi_tables.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162869): https://review.coreboot.org/c/coreboot/+/69339/comment/f6101f3e_aa1e43a4 PS2, Line 21: struct resource* res = NULL; "foo* bar" should be "foo *bar"
File src/northbridge/intel/e7505/northbridge.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162869): https://review.coreboot.org/c/coreboot/+/69339/comment/4eeac422_ece98634 PS2, Line 72: if (dev->path.type == DEVICE_PATH_DOMAIN) { braces {} are not necessary for any arm of this statement
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162869): https://review.coreboot.org/c/coreboot/+/69339/comment/be91b867_366ff496 PS2, Line 75: else if (dev->path.type == DEVICE_PATH_CPU_CLUSTER) { else should follow close brace '}'
File src/northbridge/intel/e7505/raminit.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162869): https://review.coreboot.org/c/coreboot/+/69339/comment/05de35bd_825afdc0 PS2, Line 175: while (i--) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162869): https://review.coreboot.org/c/coreboot/+/69339/comment/31ea67de_95e2d79c PS2, Line 357: hw_err: labels should not be indented
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162869): https://review.coreboot.org/c/coreboot/+/69339/comment/d00e0a79_731be7c2 PS2, Line 696: BUG(); Avoid crashing the kernel - try using WARN_ON & recovery code rather than BUG() or BUG_ON()
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162869): https://review.coreboot.org/c/coreboot/+/69339/comment/2ff5fd43_8efca5cd PS2, Line 994: hw_err: labels should not be indented
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162869): https://review.coreboot.org/c/coreboot/+/69339/comment/64525b32_07b9c249 PS2, Line 1159: mem_controller *ctrl, need consistent spacing around '*' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162869): https://review.coreboot.org/c/coreboot/+/69339/comment/19d1b5f2_7776977c PS2, Line 1189: if (!(dimm_mask & (1 << i))) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162869): https://review.coreboot.org/c/coreboot/+/69339/comment/bafd557d_ab4fb3c2 PS2, Line 1206: if (value != ERROR_SCHEME_ECC) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162869): https://review.coreboot.org/c/coreboot/+/69339/comment/35326c44_b75fd681 PS2, Line 1276: if (sdram_width.side1 == 4) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162869): https://review.coreboot.org/c/coreboot/+/69339/comment/56c00f5f_e9769093 PS2, Line 1280: if (sdram_width.side2 == 4) { braces {} are not necessary for single statement blocks
File src/southbridge/intel/i82801dx/ac97.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162869): https://review.coreboot.org/c/coreboot/+/69339/comment/f8f393c1_876d2514 PS2, Line 85: if (! timeout) { space prohibited after that '!' (ctx:BxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162869): https://review.coreboot.org/c/coreboot/+/69339/comment/2ca9a76d_42d181d9 PS2, Line 85: if (! timeout) { braces {} are not necessary for single statement blocks
File src/southbridge/intel/i82801dx/i82801dx.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162869): https://review.coreboot.org/c/coreboot/+/69339/comment/a1290244_65fb2425 PS2, Line 91: #define RTC_FAILED (1 <<2) need consistent spacing around '<<' (ctx:WxV)
File src/southbridge/intel/i82801dx/i82801dx.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162869): https://review.coreboot.org/c/coreboot/+/69339/comment/e32f5308_55f2aa49 PS2, Line 55: if (!dev->enabled) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162869): https://review.coreboot.org/c/coreboot/+/69339/comment/8706aaf8_d5d477fb PS2, Line 58: if (new_disable_mask != cur_disable_mask) { braces {} are not necessary for single statement blocks
File src/southbridge/intel/i82801dx/lpc.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162869): https://review.coreboot.org/c/coreboot/+/69339/comment/f209bf56_7f4f7657 PS2, Line 99: switch (pwr_on) { switch and case should be at the same indent