Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42798 )
Change subject: drivers/mrc_cache: Avoid unused variable assignment
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42798/1/src/drivers/mrc_cache/mrc_c...
File src/drivers/mrc_cache/mrc_cache.c:
https://review.coreboot.org/c/coreboot/+/42798/1/src/drivers/mrc_cache/mrc_c...
PS1, Line 456: boot_device_spi_flash
Note that this function has side effects. Calling it here means that it won't run in some cases.
You mean, in case the two if statements above are true?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42798
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3c94b123f4994eed9d7568b63971fd5b1d94bc09
Gerrit-Change-Number: 42798
Gerrit-PatchSet: 1
Gerrit-Owner: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Thu, 25 Jun 2020 13:26:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment