Attention is currently required from: Martin Roth, Matt DeVillier, Nico Huber, Stefan Reinauer.
CoolStar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76159?usp=email )
Change subject: mb/google/link: rework TP/TS ACPI for new Windows I2C driver ......................................................................
Patch Set 8:
(4 comments)
File src/mainboard/google/link/acpi/mainboard.asl:
https://review.coreboot.org/c/coreboot/+/76159/comment/21cdeb4d_1ffd4cdb : PS7, Line 49: ){
Missing space before `{`. Same below.
Done
https://review.coreboot.org/c/coreboot/+/76159/comment/cabb8cd3_8443b9d4 : PS7, Line 51: Method (_STA, 0, NotSerialized) // _STA: Status : { : Return (0x0F) : }
This seems superfluous, 0xf should be the default w/o _STA. Same below.
_STA added here for clarity, since the peripheral devices have it too (for consistency with google/samus)
https://review.coreboot.org/c/coreboot/+/76159/comment/59b50462_e6f16888 : PS7, Line 56: MMIO
I don't see this being used, I guess that would be the Windows driver? […]
creating a _DSM with a UUID / functions seems overkill, since MMIO here is a replacement for what would otherwise be _CRS. As mentioned earlier, _CRS can't be used because the memory overlaps the PCIe device for the IGPU
https://review.coreboot.org/c/coreboot/+/76159/comment/6b37a0d8_19665bc0 : PS7, Line 82: ISTP
code was based off Samus, where that is present
Done