[coreboot-gerrit] Change in coreboot[master]: ec/starlabs: Store the correct value for KLBE when suspending

[Felix Held (Code Review)]

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/62606 )

Change subject: ec/starlabs: Store the correct value for KLBE when suspending
......................................................................

ec/starlabs: Store the correct value for KLBE when suspending

The current code will read the raw value from the EC, which doesn't
match the respective setting in CMOS.

Switch argument will store the correct value.

Signed-off-by: Sean Rhodes 
Change-Id: Ic2a83df9a270de6d7bab295e732a6c13accbe17c
Reviewed-on: https://review.coreboot.org/c/coreboot/+/62606
Reviewed-by: Angel Pons 
Tested-by: build bot (Jenkins) 
---
M src/ec/starlabs/merlin/acpi/suspend.asl
1 file changed, 23 insertions(+), 2 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Angel Pons: Looks good to me, approved

diff --git a/src/ec/starlabs/merlin/acpi/suspend.asl b/src/ec/starlabs/merlin/acpi/suspend.asl
index a753ba6..81ae8d1 100644
--- a/src/ec/starlabs/merlin/acpi/suspend.asl
+++ b/src/ec/starlabs/merlin/acpi/suspend.asl
@@ -41,8 +41,29 @@
    		}
    	}

-		_SB.PCI0.LPCB.KLBC =
-			_SB.PCI0.LPCB.EC.ECRD (RefOf (_SB.PCI0.LPCB.EC.KLBE))
+		Switch (ToInteger (_SB.PCI0.LPCB.EC.ECRD (RefOf (_SB.PCI0.LPCB.EC.KLBE))))
+		{
+			// 0xdd == On   == 0x00
+			// 0xcc == Off  == 0x01
+			// 0xbb == Low  == 0x02
+			// 0xaa == High == 0x03
+			Case (0xdd)
+			{
+				_SB.PCI0.LPCB.KLBC = 0x00
+			}
+			Case (0xcc)
+			{
+				_SB.PCI0.LPCB.KLBC = 0x01
+			}
+			Case (0xbb)
+			{
+				_SB.PCI0.LPCB.KLBC = 0x02
+			}
+			Case (0xaa)
+			{
+				_SB.PCI0.LPCB.KLBC = 0x03
+			}
+		}
    }

/*