[coreboot-gerrit] Change in coreboot[master]: util: Add spd_tools to generate DDR4 SPDs for TGL boards

[Nick Vaccaro (Code Review)]

Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44429 )

Change subject: util: Add spd_tools to generate DDR4 SPDs for TGL boards
......................................................................

Patch Set 28:

(1 comment)

This change is ready for review.

https://review.coreboot.org/c/coreboot/+/44429/28/util/spd_tools/intel/ddr4/... 
File util/spd_tools/intel/ddr4/gen_spd.go:

https://review.coreboot.org/c/coreboot/+/44429/28/util/spd_tools/intel/ddr4/... 
PS28, Line 476: 	tRRDLFromTck = 4 * memAttribs.TCKMinPs
              : 
              : 	if tRRDLFixed < tRRDLFromTck {
              : 		return tRRDLFromTck
              : 	} else {
              : 		return tRRDLFixed
              : 	}
              : 
Technically, I think this should go into the updateTRRDLMin() to make sure that if a user specified a TRRDLMin, we still probably want to make sure that it follows the MAX rule for tRRDLMin.  But then again, if for some reason a max value was not correct, we would need the ability to override it without changing override value.  Same for the others.

Furquan, what do you think?