Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31370 )
Change subject: [WIP] console: Split loglevel for fast and slow
......................................................................
Patch Set 4: Code-Review+2
(1 comment)
https://review.coreboot.org/#/c/31370/4/src/include/console/console.h
File src/include/console/console.h:
https://review.coreboot.org/#/c/31370/4/src/include/console/console.h@65
PS4, Line 65: CONSOLE_LOG_NONE
nit: I'd at least anchor NONE as = 0 so it's clear that you can still evaluate console_log_level() as a boolean if you want to. (Also, do you know whether the use in soc/intel/quark can deal with truth values other than 1, or should we maybe change it to !!console_log_level() to be sure?)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31370
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iff56a0a3182f258200cac80e013957d598cc2130
Gerrit-Change-Number: 31370
Gerrit-PatchSet: 4
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Werner Zeh
werner.zeh@siemens.com
Gerrit-Comment-Date: Wed, 20 Feb 2019 22:44:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment