Attention is currently required from: Patrick Rudolph, Jonathan Zhang, Johnny Lin, Christian Walter, Nill Ge, TangYiwei.
Sergii Dmytruk has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69310 )
Change subject: src/drivers/ipmi: retry ipmi_get_device_id in ipmi_kcs_init
......................................................................
Patch Set 1:
(1 comment)
File src/drivers/ipmi/ipmi_kcs_ops.c:
https://review.coreboot.org/c/coreboot/+/69310/comment/d047ae1a_3eef66e4
PS1, Line 118: dev->enabled = 0;
If `dev->enabled` is set to `0` here, maybe we should just return and not get into the loop? It won't set `dev->enabled` to `1` anyway.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69310
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2b972c905fb0f8223570212432a4a10bd715f3f7
Gerrit-Change-Number: 69310
Gerrit-PatchSet: 1
Gerrit-Owner: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Nill Ge
geshijian@bytedance.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Reviewer: TangYiwei
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Jonathan Zhang
jonzhang@fb.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Nill Ge
geshijian@bytedance.com
Gerrit-Attention: TangYiwei
Gerrit-Comment-Date: Tue, 08 Nov 2022 13:23:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment