Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45159 )
Change subject: mb/google/volteer: Separate power resource for VCM ......................................................................
Patch Set 6: Code-Review+1
(6 comments)
https://review.coreboot.org/c/coreboot/+/45159/6//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45159/6//COMMIT_MSG@15 PS6, Line 15: gerit nit: ger*r*it
https://review.coreboot.org/c/coreboot/+/45159/6//COMMIT_MSG@32 PS6, Line 32: check it nit: check *if* it
https://review.coreboot.org/c/coreboot/+/45159/6/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl:
https://review.coreboot.org/c/coreboot/+/45159/6/src/mainboard/google/voltee... PS6, Line 162: CTXS(GPP_D4) Maybe the GPIO should be defined in some variant-specific header?
https://review.coreboot.org/c/coreboot/+/45159/6/src/mainboard/google/voltee... PS6, Line 168: (( One set of parentheses is enough:
If (REFC == 0)
https://review.coreboot.org/c/coreboot/+/45159/6/src/mainboard/google/voltee... PS6, Line 187: } \n
https://review.coreboot.org/c/coreboot/+/45159/6/src/mainboard/google/voltee... PS6, Line 201: (( Same here, one set of parentheses is enough.