Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34157 )
Change subject: soc/intel/cannonlake: Add device Ids for CFL Refresh support ......................................................................
Patch Set 10:
(3 comments)
https://review.coreboot.org/c/coreboot/+/34157/8//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34157/8//COMMIT_MSG@7 PS8, Line 7: soc/intel/cannonlake: Add device Ids for CFL Refresh support
which specific IDs?
The CNP-H IDs for instance. It doesn't matter much and I'm not sure when "Refresh" exactly started.
https://review.coreboot.org/c/coreboot/+/34157/8/src/soc/intel/cannonlake/bo... File src/soc/intel/cannonlake/bootblock/report_platform.c:
https://review.coreboot.org/c/coreboot/+/34157/8/src/soc/intel/cannonlake/bo... PS8, Line 109: 2
Doesn't the '2' in '(6+2)' refer to 'GT2'?
Yes, that's what I meant (it's hard to spot but I highlighted the 2 in 6+2 in Gerrit). Generally, I don't see a reason to mention the number of CPU cores for the graphics device (which this table is about). And I think it can even be wrong (e.g. below the 8+2 could also be a 6+2, afaik).
https://review.coreboot.org/c/coreboot/+/34157/8/src/soc/intel/common/block/... File src/soc/intel/common/block/systemagent/systemagent.c:
https://review.coreboot.org/c/coreboot/+/34157/8/src/soc/intel/common/block/... PS8, Line 4: 2019
This should reflect the year when some creative addition was made, not […]
Ack