Attention is currently required from: Annie Chen, Arthur Heymans, Chen, Gang C, Christian Walter, David Hendricks, Jincheng Li, Johnny Lin, Naresh Solanki, Nill Ge, Shuo Liu, TangYiwei, Tim Chu.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79878?usp=email )
Change subject: soc/intel/xeon_sp: Support multiple PCI segment groups
......................................................................
Patch Set 2:
(2 comments)
Patchset:
PS2:
After I set CONFIG_ECAM_SEGMENT_COUNT to 1, I see build error for AC: […]
I'll rebase on main. It would be nice to get https://review.coreboot.org/c/coreboot/+/78333 in first to simplify the modifications needed for PCI segment group support.
File src/soc/intel/xeon_sp/spr/soc_acpi.c:
https://review.coreboot.org/c/coreboot/+/79878/comment/29107f97_ba98e837 :
PS2, Line 256: stack_enabled = false;
shouldn't we continue here?
No, as that would leave the DSDT with missing resources. The OS' AML interpreter will complain that tres doesn't exist.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79878?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I0ba5e426123234979d746d3bdfc1ddfbd71c3447
Gerrit-Change-Number: 79878
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Annie Chen
chen.annieet@inventec.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Chen, Gang C
gang.c.chen@intel.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Jincheng Li
jincheng.li@intel.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Naresh Solanki
naresh.solanki@9elements.com
Gerrit-Reviewer: Nill Ge
geshijian@bytedance.com
Gerrit-Reviewer: Shuo Liu
shuo.liu@intel.com
Gerrit-Reviewer: TangYiwei
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Chen, Gang C
gang.c.chen@intel.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Annie Chen
chen.annieet@inventec.com
Gerrit-Attention: David Hendricks
david.hendricks@gmail.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Shuo Liu
shuo.liu@intel.com
Gerrit-Attention: Nill Ge
geshijian@bytedance.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Jincheng Li
jincheng.li@intel.com
Gerrit-Attention: TangYiwei
Gerrit-Attention: Naresh Solanki
naresh.solanki@9elements.com
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Comment-Date: Fri, 19 Jan 2024 10:21:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Johnny Lin
Johnny_Lin@wiwynn.com
Comment-In-Reply-To: Shuo Liu
shuo.liu@intel.com
Gerrit-MessageType: comment