[coreboot-gerrit] Change in ...coreboot[master]: soc/intel/cannonlake: Disable ACPI mode as part of pmc_soc_init

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31614 )

Change subject: soc/intel/cannonlake: Disable ACPI mode as part of pmc_soc_init
......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/#/c/31614/3/src/soc/intel/cannonlake/pmc.c 
File src/soc/intel/cannonlake/pmc.c:

https://review.coreboot.org/#/c/31614/3/src/soc/intel/cannonlake/pmc.c@176 
PS3, Line 176: pmc_set_acpi_mode();
> then do you see PMC device in bus? else its not possible to call this function

That function actually doesn't talk directly to the PMC device: https://review.coreboot.org/cgit/coreboot.git/tree/src/soc/intel/common/bloc...