[coreboot-gerrit] Change in ...coreboot[master]: soc/intel/cannonlake: Clear PMCON status bits

[Rizwan Qureshi (Code Review)]

Rizwan Qureshi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31902 )

Change subject: soc/intel/cannonlake: Clear PMCON status bits
......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/#/c/31902/3/src/soc/intel/cannonlake/pmutil.c 
File src/soc/intel/cannonlake/pmutil.c:

https://review.coreboot.org/#/c/31902/3/src/soc/intel/cannonlake/pmutil.c@14... 
PS3, Line 146: pmc_clear_suspwrflr
> Does FSP rely on these values? If yes, what for? Ideally I was thinking of doing this in pmc_init instead of pch_finalize.

Haven't looked at the FSP code, just wanted to steer clear if it does. Maybe we can have a look.