Attention is currently required from: Subrata Banik, Tim Wawrzynczak, Patrick Rudolph. Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60401 )
Change subject: soc/intel/alderlake: Check clkreq overlap ......................................................................
Patch Set 4:
(3 comments)
File src/soc/intel/alderlake/romstage/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/60401/comment/a58826bd_1603847a PS3, Line 51: 32 bit
nit: 32-bit
done
https://review.coreboot.org/c/coreboot/+/60401/comment/1548c391_e6346a3a PS3, Line 55: u32
nit: uint32_t […]
Done
https://review.coreboot.org/c/coreboot/+/60401/comment/ed35126c_0b397d5b PS3, Line 63: printk(BIOS_WARNING, "Found overlapped clkreq assignment on clk req %d\n" : , cfg[i].clk_req);
how are we protecting the overlap now? just serial msg is enough or you would like to skip the overl […]
I didn't find any protection actually, so there is a chance 2 root port can use one clkreq. I don't want to skip programming since i'm not pretty sure if there is really a design need this, so printing a warning msg should be good enough.