Julius Werner has posted comments on this change by Yu-Ping Wu. ( https://review.coreboot.org/c/coreboot/+/83494?usp=email )
Change subject: security/vboot: Introduce vbnv_platform_init_cmos()
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
Is this really a vboot thing? Doesn't that bank selection affect all coreboot use of the CMOS, not just vboot (e.g. CONFIG_USE_OPTION_TABLE if it's enabled)? I'm wondering if this shouldn't go into the main CMOS driver instead (i.e. `__cmos_init()`).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83494?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic899a827bd6bb8ab1473f8c6c03b9fde96ea6823
Gerrit-Change-Number: 83494
Gerrit-PatchSet: 4
Gerrit-Owner: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-Comment-Date: Thu, 25 Jul 2024 02:34:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No