Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46607 )
Change subject: sec/intel/txt: Add support for running SCLEAN in romstage
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46607/3/src/security/intel/txt/gets...
File src/security/intel/txt/getsec_sclean.S:
https://review.coreboot.org/c/coreboot/+/46607/3/src/security/intel/txt/gets...
PS3, Line 55: needs
This code make platforms specific assumptions, which it shouldn't.
SNB, BYT, HSW, BDW, SKL, KBL all require this to be done in two separate steps, as per BWGs. Since this code is only necessary on LT-CX, I think it's a reasonable assumption.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46607
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I77b237342e0c98eda974f87944f1948d197714db
Gerrit-Change-Number: 46607
Gerrit-PatchSet: 3
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 21 Oct 2020 23:06:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
siro@das-labor.org
Gerrit-MessageType: comment