[coreboot-gerrit] [XS] Change in coreboot[main]: src/include: Introduce a new BIT_FLAG_32(x) macro

[Saurabh Mishra (Code Review)]

Attention is currently required from: Ashish Kumar Mishra, Julius Werner, Jérémy Compostella, Karthik Ramasubramanian, Martin Roth, Pratikkumar V Prajapati, Subrata Banik.

Saurabh Mishra has posted comments on this change by Saurabh Mishra. ( https://review.coreboot.org/c/coreboot/+/84142?usp=email )

Change subject: src/include: Introduce a new BIT_FLAG_32(x) macro
......................................................................

Patch Set 17:

(3 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/84142/comment/f623aeb9_5631856d?usp... :
PS17, Line 11: 1ul is 64 bits wide
> Is it true even for 32 bit systems?

On most 32-bit systems, unsigned long (1ul) is 32 bits wide. But nn most 64-bit systems (using the LP64 model), unsigned long (1ul) is 64 bits wide.

File src/include/types.h:

https://review.coreboot.org/c/coreboot/+/84142/comment/90b1dcc1_ef43d899?usp... :
PS17, Line 26: defined
> used

Done

https://review.coreboot.org/c/coreboot/+/84142/comment/9f39c467_dec5ce24?usp... :
PS17, Line 27:  * used a different name.
> s/use/used/

Acknowledged