Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42832 )
Change subject: mb/google/zork: Add Bluetooth reset gpios to devicetree
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42832/3/src/mainboard/google/zork/v...
File src/mainboard/google/zork/variants/baseboard/devicetree_trembyle.cb:
https://review.coreboot.org/c/coreboot/+/42832/3/src/mainboard/google/zork/v...
PS3, Line 272: GPIO_14
Trembyle EVT 2. […]
APGIO14 was changed from USB_A1_FAULT_ODL input to BT_DISABLE output in version 3 of the schematic. We handle this override in zork/variants/*/gpio.c. I guess it may be necessary to add an override for this ACPI entry too?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42832
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I14e3ef099d5b8f48c915b41284039b3508dec975
Gerrit-Change-Number: 42832
Gerrit-PatchSet: 4
Gerrit-Owner: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Wed, 15 Jul 2020 17:23:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Gerrit-MessageType: comment