24 Jul
2019
24 Jul
'19
2:21 p.m.
Johanna Schander has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34537 )
Change subject: src/device/oprom: Fix bootsplash display code for optionroms ......................................................................
Patch Set 10:
Patch Set 8:
IMHO it is now good time to move bootsplash code entirely outside oprom directory, even if the dependency still remains after this commit.
I thought about it and decided against it: - It is only called from optionroms - It should only be compiled, if oprom execution is selected as well.
Therefore i left it there. (For now)
--
To view, visit https://review.coreboot.org/c/coreboot/+/34537
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5ab7b8a0f28badaa16e25dbe807158870d06e26a
Gerrit-Change-Number: 34537
Gerrit-PatchSet: 10
Gerrit-Owner: Johanna Schander coreboot@mimoja.de
Gerrit-Reviewer: Christoph Pomaska github@aufmachen.jetzt
Gerrit-Reviewer: Johanna Schander coreboot@mimoja.de
Gerrit-Reviewer: Jonathan Neuschäfer j.neuschaefer@gmx.net
Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 24 Jul 2019 12:21:55 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment