Attention is currently required from: Hung-Te Lin, Jarried Lin, Kenji Yu, Yu-Ping Wu.
Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85516?usp=email )
Change subject: soc/mediatek/mt8196: Initialize SSPM ......................................................................
Patch Set 15: Code-Review+1
(2 comments)
File src/soc/mediatek/common/sspm.c:
https://review.coreboot.org/c/coreboot/+/85516/comment/62b4c695_26274b9f?usp... : PS15, Line 19: void sspm_init(void) : { : sspm.load_buffer = _dram_dma; : sspm.buffer_size = REGION_SIZE(dram_dma); : : mtk_init_mcu(&sspm); : } ``` __weak void sspm_enable_sram(void) { /* do nothing. */ }
void sspm_init(void) { sspm_enable_sram();
sspm.load_buffer = _dram_dma; sspm.buffer_size = REGION_SIZE(dram_dma);
mtk_init_mcu(&sspm); } ```
File src/soc/mediatek/mt8196/soc.c:
https://review.coreboot.org/c/coreboot/+/85516/comment/d8a338ae_dcf3c752?usp... : PS15, Line 30: sspm_enable_sram(); remove