[coreboot-gerrit] [XS] Change in coreboot[main]: soc/intel/xeon_sp/Kconfig: Disable ANSI escape code

[Angel Pons (Code Review)]

Attention is currently required from: Christian Walter, David Hendricks, Johnny Lin, Jonathan Zhang, Nico Huber, Patrick Rudolph, Shuo Liu, Tim Chu, Yan-tingX Chen.

Angel Pons has posted comments on this change by Shuo Liu. ( https://review.coreboot.org/c/coreboot/+/83610?usp=email )

Change subject: soc/intel/xeon_sp/Kconfig: Disable ANSI escape code
......................................................................

Patch Set 1:

(2 comments)

File src/soc/intel/xeon_sp/Kconfig:

https://review.coreboot.org/c/coreboot/+/83610/comment/cc65bf38_33de3cb3?usp... :
PS1, Line 113: config CONSOLE_USE_ANSI_ESCAPES
Unless there is a technical requirement to disable this *for the entire Xeon-SP family*, I would highly recommend using site-local instead: https://doc.coreboot.org/tutorial/managing_local_additions.html

https://review.coreboot.org/c/coreboot/+/83610/comment/de1d4bde_4685bcc9?usp... :
PS1, Line 114: 	bool "Use ANSI escape sequences for console highlighting"
Repeating the type/prompt is not necessary.