19 Jun
2023
19 Jun
'23
2:22 a.m.
Attention is currently required from: Kapil Porwal, Pratikkumar V Prajapati, Subrata Banik, Tarun Tuli.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74770?usp=email )
Change subject: mainboard/google/rex: Enable crashlog ......................................................................
Patch Set 18: Code-Review+2
(1 comment)
Patchset:
PS18: Why need two sram? One is for IOE? In this case I would suggest update device tree by CPU in variant.c
--
To view, visit https://review.coreboot.org/c/coreboot/+/74770?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3d3a9fb41d1293f021ad9de9b29c756cb7559373
Gerrit-Change-Number: 74770
Gerrit-PatchSet: 18
Gerrit-Owner: Pratikkumar V Prajapati pratikkumar.v.prajapati@intel.com
Gerrit-Reviewer: Eric Lai eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Kapil Porwal kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Tarun Tuli taruntuli@google.com
Gerrit-Attention: Subrata Banik subratabanik@google.com
Gerrit-Attention: Kapil Porwal kapilporwal@google.com
Gerrit-Attention: Pratikkumar V Prajapati pratikkumar.v.prajapati@intel.com
Gerrit-Comment-Date: Mon, 19 Jun 2023 00:22:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment