Attention is currently required from: Arthur Heymans, Jérémy Compostella.
Angel Pons has posted comments on this change by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/84040?usp=email )
Change subject: ext_stage_cache: Make sure variables are initializated ......................................................................
Patch Set 3: Code-Review+1
Copied votes on follow-up patch sets have been updated: * Code-Review+1 has been copied to patch set 4 (copy condition: "changekind:NO_CHANGE OR changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN").
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84040/comment/89cdcd07_d07ba20f?usp... : PS3, Line 7: initializated initialized
File src/lib/ext_stage_cache.c:
https://review.coreboot.org/c/coreboot/+/84040/comment/3de1bf5d_39c9c862?usp... : PS3, Line 20: printk(BIOS_ERR, "Could not find external stage cache"); `stage_cache_external_region` already prints an error, do we need to print an error on the caller side too?