Joel Kitching has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36844 )
Change subject: security/vboot: Remove buffer_size from struct vboot_working_data ......................................................................
Patch Set 2:
(4 comments)
Looks good after fixing the comment.
https://review.coreboot.org/c/coreboot/+/36844/1/src/lib/coreboot_table.c File src/lib/coreboot_table.c:
https://review.coreboot.org/c/coreboot/+/36844/1/src/lib/coreboot_table.c@23... PS1, Line 235: vbwb->range_size = 0;
eventually want to get to the point where we can put this into add_cbmem_pointers()
Since the cbmem entry name is sort of a misnomer, but would suit our future use, shall we just keep it the same (VBOOT_WORKBUF)?
https://review.coreboot.org/c/coreboot/+/36844/2/src/lib/coreboot_table.c File src/lib/coreboot_table.c:
https://review.coreboot.org/c/coreboot/+/36844/2/src/lib/coreboot_table.c@23... PS2, Line 232: VB2_KERNEL_WORKBUF_RECOMMENDED_SIZE (VB2_... - wd->buffer_offset) Or just say "a known value"
https://review.coreboot.org/c/coreboot/+/36844/2/src/lib/coreboot_table.c@23... PS2, Line 232: could s/could //
https://review.coreboot.org/c/coreboot/+/36844/1/src/security/vboot/common.c File src/security/vboot/common.c:
https://review.coreboot.org/c/coreboot/+/36844/1/src/security/vboot/common.c... PS1, Line 80: size
Done
It used to fit. 12 K < 64 K (uint16_t).