Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42486 )
Change subject: Revert "soc/amd/common/block/acpimmio: Update acpimmio for psp_verstage" ......................................................................
Patch Set 5:
Patch Set 5:
Shouldn't we combine this w/ a resulting full solution? I suspect we should let Martin's series land then modify files as needed.
Once ARCH_VERSTAGE_ARM lands we are forced to squash several commits together to satisfy jenkins every-commit-builds requirement. From what it appears to me, all the forking and splitting of source files in Martin's series is undesireable and unnecessary, if we take a closer look at it.
In some recent intel-car change-series, I was requested to hide cache-as-ram related symbols from romstage because they only had proper references in bootblock. Following this logic, all x86-centric #defines of memory base addresses should be guarded with ENV_X86. I believe many of those continue to leak into psp-verstage currently, although most of them will be handled by --gc-sections.