Attention is currently required from: Eric Lai, Jakub Czapiga, John Su, John Zhao, Kapil Porwal, Sean Rhodes, Subrata Banik.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72909?usp=email )
Change subject: soc/intel/common/tcss: Configure USB-C ports with attached devices
......................................................................
Patch Set 5:
(2 comments)
File src/soc/intel/common/block/tcss/tcss.c:
https://review.coreboot.org/c/coreboot/+/72909/comment/19a43cea_59b9fc67 :
PS4, Line 357: if ((ret < 0) || !mux_info.usb)
could you please change it as below […]
Done
https://review.coreboot.org/c/coreboot/+/72909/comment/95bfe50b_df4487bf :
PS4, Line 361: ret = send_pmc_connect_request(i, &mux_info, port_info);
Correct. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/72909?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I69522dbcc8cae6bbf41659ae653107d0e031c812
Gerrit-Change-Number: 72909
Gerrit-PatchSet: 5
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-Reviewer: John Su
john_su@compal.corp-partner.google.com
Gerrit-Reviewer: John Zhao
john.zhao@intel.corp-partner.google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: CoolStar
coolstarorganization@gmail.com
Gerrit-CC: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-CC: Jakub Czapiga
jacz@semihalf.com
Gerrit-CC: Tim Crawford
tcrawford@system76.com
Gerrit-Attention: John Su
john_su@compal.corp-partner.google.com
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Attention: Jakub Czapiga
jacz@semihalf.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: John Zhao
john.zhao@intel.corp-partner.google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Comment-Date: Thu, 03 Aug 2023 12:56:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Kapil Porwal
kapilporwal@google.com
Gerrit-MessageType: comment