Attention is currently required from: Angel Pons, Felix Singer, Pratikkumar V Prajapati.
Elyes Haouas has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/83110?usp=email )
Change subject: inteltool/lpc.c: Add PCI_DEVICE_ID_INTEL_H67 ......................................................................
Patch Set 2:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83110/comment/c1228db9_bfd1e0e5?usp... : PS1, Line 11: ./inteltool -l
Do we need the inteltool output in the commit message?
it doesn't hurt :)
File util/inteltool/lpc.c:
https://review.coreboot.org/c/coreboot/+/83110/comment/bae1e31b_514e0d01?usp... : PS1, Line 90: case PCI_DEVICE_ID_INTEL_H67:
Why not add at least the rest of CPT IDs?
looks better to me
https://review.coreboot.org/c/coreboot/+/83110/comment/728d76c9_548ddf2c?usp... : PS1, Line 120: bc = pci_read_long(dev, SUNRISE_LPC_BC);
Does this actually exist on CPT? I would prefer to have a special case for older platforms that only […]
Out of scope of current patch