Attention is currently required from: Hung-Te Lin, Xinxiong Xu, Yidi Lin, Yu-Ping Wu.
Yang Wu has posted comments on this change by Yang Wu. ( https://review.coreboot.org/c/coreboot/+/85742?usp=email )
Change subject: mb/google/corsola: Add new board variant Wyrdeer ......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/corsola/panel_wyrdeer.c:
https://review.coreboot.org/c/coreboot/+/85742/comment/cb6a941b_99edb9d2?usp... : PS2, Line 12: static void mipi_panel_power_on(void) : { : const struct tps65132s_reg_setting reg_settings[] = { : { PMIC_TPS65132_VPOS, 0x14, 0x1F }, : { PMIC_TPS65132_VNEG, 0x14, 0x1F }, : { PMIC_TPS65132_DLYX, 0x95, 0xFF }, : { PMIC_TPS65132_ASSDD, 0x5b, 0xFF }, : }; : const struct tps65132s_cfg cfg = { : .i2c_bus = PMIC_I2C_BUS, : .en = GPIO_EN_PP3300_DISP_X, : .sync = GPIO_TCHPAD_INT_ODL, : .settings = reg_settings, : .setting_counts = ARRAY_SIZE(reg_settings), : }; : : mainboard_set_regulator_voltage(MTK_REGULATOR_VIO18, 1800000); : mtk_i2c_bus_init(PMIC_I2C_BUS, I2C_SPEED_FAST); : : if (is_pmic_aw37503(PMIC_I2C_BUS)) { : printk(BIOS_DEBUG, "Initialize and power on PMIC AW37503\n"); : aw37503_init(PMIC_I2C_BUS); : gpio_output(GPIO_EN_PP3300_DISP_X, 1); : mdelay(2); : gpio_output(GPIO_TCHPAD_INT_ODL, 1); : mdelay(3); : } else if (tps65132s_setup(&cfg) != CB_SUCCESS) { : printk(BIOS_ERR, "Failed to setup tps65132s\n"); : } : : /* DISP_RST_1V8_L */ : gpio_output(GPIO_EDPBRDG_RST_L, 1); : mdelay(1); : gpio_output(GPIO_EDPBRDG_RST_L, 0); : udelay(20); : gpio_output(GPIO_EDPBRDG_RST_L, 1); : }
This function is identical to the function in `panel_starmie.c`. Move it to a separate file.
There is one difference between starmie and wyrdeer, starmie uses `GPIO_EN_PP3300_SDBRDG_X` as `EN_PP6000_MIPI_DISP_150MA` pin, but wyrdeer uses `GPIO_TCHPAD_INT_ODL`