Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43761 )
Change subject: mb/google/dedede: Remove Rcomp resistor and target values
......................................................................
Patch Set 1: Code-Review+2
The Rcomp resistor values are fixed as per platform design guidelines, right? If so, it makes sense to automatically determine the correct values.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43761
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia130765e2cb91d6a39ad00ebbab20e7e87fa42d1
Gerrit-Change-Number: 43761
Gerrit-PatchSet: 1
Gerrit-Owner: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 24 Jul 2020 22:58:39 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment