build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68903 )
Change subject: intel/common/basecode/debug: Fix potential NULL pointer dereference ......................................................................
Patch Set 1:
(11 comments)
Commit Message:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161437): https://review.coreboot.org/c/coreboot/+/68903/comment/3b74381e_7e77d63f PS1, Line 9: Found-by: Klockwork Non-standard signature: Found-by:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161437): https://review.coreboot.org/c/coreboot/+/68903/comment/dca2fd0b_2a8ecd80 PS1, Line 9: Found-by: Klockwork Unrecognized email address: 'Klockwork'
File src/soc/intel/common/basecode/debug/debug_feature.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161437): https://review.coreboot.org/c/coreboot/+/68903/comment/a8dc6566_afbca13e PS1, Line 35: if(spi_flash_dev == NULL) { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161437): https://review.coreboot.org/c/coreboot/+/68903/comment/50e0cab0_d201bdd1 PS1, Line 35: if(spi_flash_dev == NULL) { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161437): https://review.coreboot.org/c/coreboot/+/68903/comment/b1b21b9a_da120cbc PS1, Line 35: if(spi_flash_dev == NULL) { space required before the open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161437): https://review.coreboot.org/c/coreboot/+/68903/comment/9551117f_4a13bd4c PS1, Line 36: printk(BIOS_ERR, "Failed to Initialize boot device SPI flash\n"); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161437): https://review.coreboot.org/c/coreboot/+/68903/comment/5bd8d834_61b40df0 PS1, Line 36: printk(BIOS_ERR, "Failed to Initialize boot device SPI flash\n"); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161437): https://review.coreboot.org/c/coreboot/+/68903/comment/19b4b015_4e6d7982 PS1, Line 37: return CB_ERR; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161437): https://review.coreboot.org/c/coreboot/+/68903/comment/5b275205_9d94a98d PS1, Line 37: return CB_ERR; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161437): https://review.coreboot.org/c/coreboot/+/68903/comment/7b0a0429_5033bec2 PS1, Line 38: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161437): https://review.coreboot.org/c/coreboot/+/68903/comment/52e8869b_1db82283 PS1, Line 38: } please, no spaces at the start of a line