12 Aug
2021
12 Aug
'21
11:44 p.m.
Attention is currently required from: Jakub Czapiga, Julius Werner, Jan Dabros. Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56931 )
Change subject: tests/Makefile.inc: Change assignments to immediate and fix style ......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1: Have you verified that using := instead of = does not have any unintended effects? coreboot gerrit doesn't require TEST= lines in commit messages like chromiumos gerrit does, but I still find it is a good practice to describe how you tested the change and verified that it still works.
--
To view, visit https://review.coreboot.org/c/coreboot/+/56931
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idf07b5a836b33cd80c3533e582e2a1916a7bd45d
Gerrit-Change-Number: 56931
Gerrit-PatchSet: 1
Gerrit-Owner: Jakub Czapiga jacz@semihalf.com
Gerrit-Reviewer: Jan Dabros jsd@semihalf.com
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Jakub Czapiga jacz@semihalf.com
Gerrit-Attention: Julius Werner jwerner@chromium.org
Gerrit-Attention: Jan Dabros jsd@semihalf.com
Gerrit-Comment-Date: Thu, 12 Aug 2021 14:44:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment