Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45273 )
Change subject: nb/intel/i945/acpi: Convert igd.asl to ASL+ Syntax ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45273/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45273/4//COMMIT_MSG@11 PS4, Line 11: "Store (Or(ShiftLeft (Arg0, 4), 0xf), ^^DSPC.BRTC)" and "^^DSPC.BRTC = ((Arg0 << 0x04) | 0x0F)" If it should be the same, report this to the IASL developers?
https://review.coreboot.org/c/coreboot/+/45273/4/src/northbridge/intel/i945/... File src/northbridge/intel/i945/acpi/igd.asl:
https://review.coreboot.org/c/coreboot/+/45273/4/src/northbridge/intel/i945/... PS4, Line 42: } Due to the problem with the IASL optimization, split the commit into two, where one doesn’t change the binary, and the other does?