Eric Peers has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43678 )
Change subject: soc/amd/picasso: Don't run dcache_clean_all() in psp_verstage
......................................................................
Patch Set 4: Code-Review+1
I considered another option over chat with Martin. Why not make the dcache_clean_all the weak function?
The benefit: One less layer
The cost: PSP has it permanently defined to do nothing. We might actually want such a function to invalidate a PSP cache. Name of function also doesn't follow actual implementation which is confusing.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43678
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6775b2e049d6cfd9f78f2e07a941f6cc5be254b8
Gerrit-Change-Number: 43678
Gerrit-PatchSet: 4
Gerrit-Owner: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Eric Peers
epeers@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kangheui Won
khwon@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 22 Jul 2020 20:52:17 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment