[coreboot-gerrit] Change in coreboot[master]: arch/x86: Init firmware pointer for EC SMSC KBC1098/KBC1126 at build ...

[Angel Pons (Code Review)]

Attention is currently required from: Arthur Heymans, Bill XIE, Nico Huber, Patrick Rudolph, Julius Werner, Michael Niewöhner, Kyösti Mälkki, Aaron Durbin.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51671 )

Change subject: arch/x86: Init firmware pointer for EC SMSC KBC1098/KBC1126 at build time
......................................................................

Patch Set 29:

(3 comments)

File src/arch/x86/Kconfig:

https://review.coreboot.org/c/coreboot/+/51671/comment/da66efb6_941ab274 
PS29, Line 357: config ECFW_PTR_SIZE
              : 	int
              : 	help
              : 	   Size of reserved space for EC firmware pointer
This is completely unused

File src/ec/hp/kbc1126/Kconfig:

https://review.coreboot.org/c/coreboot/+/51671/comment/32bc7215_61baff1b 
PS29, Line 30: if EC_HP_KBC1126
This guard is redundant, because `EC_HP_KBC1126_ECFW_IN_CBFS` already depends on `EC_HP_KBC1126`. Please remove.

File src/ec/hp/kbc1126/Makefile.inc:

https://review.coreboot.org/c/coreboot/+/51671/comment/6f49bd23_92c38ae5 
PS29, Line 7: bootblock-y += ecfw_ptr.c
This should always be compiled in when `EC_HP_KBC1126_ECFW_IN_CBFS` is true, not only when `EC_HP_KBC1126_FIRMWARE` is true.