Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46250 )
Change subject: soc/intel/cannonlake: Improve memcfg comments
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46250/1/src/soc/intel/cannonlake/in...
File src/soc/intel/cannonlake/include/soc/cnl_memcfg_init.h:
https://review.coreboot.org/c/coreboot/+/46250/1/src/soc/intel/cannonlake/in...
PS1, Line 102: or left blank
fsp only has defaults for some SKUs and this even depends on which fsp base code was used (the older […]
I'll have to rework the comment anyway. 573387 is not a good reference
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46250
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1142ab500fd18176b174a5080f78c5c566c9ce25
Gerrit-Change-Number: 46250
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Michael Niewöhner
foss@mniewoehner.de
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Tue, 13 Oct 2020 10:47:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Michael Niewöhner
foss@mniewoehner.de
Gerrit-MessageType: comment