[coreboot-gerrit] Change in coreboot[master]: drivers/spi/tpm: Enable long cr50 ready pulses for Tiger Lake systems

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43741 )

Change subject: drivers/spi/tpm: Enable long cr50 ready pulses for Tiger Lake systems
......................................................................

Patch Set 22:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43741/22/src/drivers/spi/tpm/tpm.c 
File src/drivers/spi/tpm/tpm.c:

https://review.coreboot.org/c/coreboot/+/43741/22/src/drivers/spi/tpm/tpm.c@... 
PS22, Line 51: tatic int cr50_firmware_version[3];
> Well that isn't happening in this patch and the control flow isn't currently good by doing this. […]

Agreed. I was just pointing out that in the changes that Karthik is working on, we are going to need some getter function to obtain cr50 firmware version which will have to be stashed in some place other than the stack. I agree that this change doesn't need it and so what you suggested makes perfect sense.