Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44481 )
Change subject: soc/amd/common: add single function ACPI PM1 GPE helpers ......................................................................
Patch Set 1: Code-Review+2
(2 comments)
https://review.coreboot.org/c/coreboot/+/44481/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44481/1//COMMIT_MSG@12 PS1, Line 12: ramsatage nit: ramstage
https://review.coreboot.org/c/coreboot/+/44481/1/src/soc/amd/common/block/in... File src/soc/amd/common/block/include/amdblocks/acpi.h:
https://review.coreboot.org/c/coreboot/+/44481/1/src/soc/amd/common/block/in... PS1, Line 26: uint16_t aligning_field; Is this for structure alignment?