Attention is currently required from: Hung-Te Lin, Roger Lu, Yu-Ping Wu, Yuchen Huang.
Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46878 )
Change subject: soc/mediatek/mt8192: add clkbuf and srclken_rc MT6359P driver
......................................................................
Patch Set 58:
(3 comments)
File src/soc/mediatek/mt8192/include/soc/srclken_rc.h:
https://review.coreboot.org/c/coreboot/+/46878/comment/d4b0f5f2_0e1bedee
PS50, Line 6: (0)
replace this by enum?
removed
https://review.coreboot.org/c/coreboot/+/46878/comment/e714a763_1231fdfc
PS50, Line 7: #if !MTK_SRCLKEN_RC_BRINGUP
: #define MTK_SRCLKEN_RC_SUPPORT
: #endif
I'd prefer a Kconfig for this (and only do the logic in *. […]
Done
https://review.coreboot.org/c/coreboot/+/46878/comment/f9d199a8_c2a1e5a3
PS50, Line 10: (1)
replace by enum
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46878
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I947bf14df7a307bf359c590c2a20265882b3f1be
Gerrit-Change-Number: 46878
Gerrit-PatchSet: 58
Gerrit-Owner: Roger Lu
roger.lu@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Ran Bi
ran.bi@mediatek.com
Gerrit-Reviewer: Roger Lu
roger.lu@mediatek.com
Gerrit-Reviewer: Xi Chen
xixi.chen@mediatek.com
Gerrit-Reviewer: Yidi Lin
yidi.lin@mediatek.com
Gerrit-Reviewer: Yuchen Huang
yuchen.huang@mediatek.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: hsin-hsiung wang
hsin-hsiung.wang@mediatek.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Roger Lu
roger.lu@mediatek.corp-partner.google.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: Yuchen Huang
yuchen.huang@mediatek.corp-partner.google.com
Gerrit-Comment-Date: Mon, 11 Jan 2021 07:27:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hung-Te Lin
hungte@chromium.org
Gerrit-MessageType: comment