Attention is currently required from: Angel Pons, Arthur Heymans, Nicholas Chin, Elyes Haouas.
Fabian Groffen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73097 )
Change subject: mb/asrock/b75m-itx: Add Sandy/Ivy Bridge board B75M-ITX ......................................................................
Patch Set 2:
(8 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/73097/comment/7397d0a5_4882a9e0 PS2, Line 30: i915
nit: That's the name of the Linux kernel driver. […]
Done
File src/mainboard/asrock/b75m-itx/Kconfig:
https://review.coreboot.org/c/coreboot/+/73097/comment/ea189ed7_46017ea7 PS2, Line 5: config BOARD_SPECIFIC_OPTIONS
Your board lacks a serial port, you should add `select NO_UART_ON_SUPERIO`
Done
File src/mainboard/asrock/b75m-itx/acpi/pci.asl:
PS2:
Remove, your board does not have a conventional PCI port.
Done
File src/mainboard/asrock/b75m-itx/acpi/superio.asl:
https://review.coreboot.org/c/coreboot/+/73097/comment/4aa59f77_4c39d21f PS2, Line 3: #undef SUPERIO_DEV : #define SUPERIO_DEV SIO0 : #define SUPERIO_PNP_BASE 0x2e
This does nothing. You should include some pc80 keyboard. […]
Done
File src/mainboard/asrock/b75m-itx/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/73097/comment/e334a04f_8f146146 PS2, Line 84: device pci 1e.0 on # PCI bridge : subsystemid 0x1849 0x244e : end
Disable, your board does not have a conventional PCI port.
Hmmm, but lspci with the vendor bios reported:
00:1e.0 PCI bridge: Intel Corporation 82801 PCI Bridge (rev a4)
is that not the same thing then?
File src/mainboard/asrock/b75m-itx/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/73097/comment/764446a8_134e3265 PS2, Line 26: #include "acpi/pci.asl"
Remove, your board does not have a conventional PCI port.
Done
File src/mainboard/asrock/b75m-itx/early_init.c:
https://review.coreboot.org/c/coreboot/+/73097/comment/0d1b2220_b60666eb PS2, Line 19: read_spd(&spd[0], 0x50, id_only); : read_spd(&spd[1], 0x51, id_only); : read_spd(&spd[2], 0x52, id_only); : read_spd(&spd[3], 0x53, id_only);
Your board only has 2 DIMM slots. […]
Ack
File src/mainboard/asrock/b75m-itx/gpio.c:
PS2:
How did you make this file? Ideally, you should use `util/autoport`, get the logs while running vend […]
I'll try that, but I didn't have much luck in getting autoport to run last few times I tried.