[coreboot-gerrit] [S] Change in coreboot[main]: dsm:dsm test not to merge. to test

[Poornima Tom (Code Review)]

Attention is currently required from: Poornima Tom.

Hello Poornima Tom,

I'd like you to do a code review.
Please visit

https://review.coreboot.org/c/coreboot/+/84096?usp=email

to review the following change.

Change subject: dsm:dsm test not to merge. to test
......................................................................

dsm:dsm test
not to merge. to test

Change-Id: I979ddb5a9993a491ea48edaaf2a5ad2653430799
Signed-off-by: Poornima Tom 
---
M src/drivers/wifi/generic/acpi.c
1 file changed, 14 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/84096/1

diff --git a/src/drivers/wifi/generic/acpi.c b/src/drivers/wifi/generic/acpi.c
index 81620f7..ae63cf9 100644
--- a/src/drivers/wifi/generic/acpi.c
+++ b/src/drivers/wifi/generic/acpi.c
@@ -672,8 +672,9 @@
     * If device type is PCI, ensure that the device has Intel vendor ID. CBFS SAR and SAR
     * ACPI tables are currently used only by Intel WiFi devices.
     */
-	if (dev->path.type == DEVICE_PATH_PCI && dev->vendor != PCI_VID_INTEL)
-		return;
+	if (dev->path.type == DEVICE_PATH_PCI && dev->vendor != PCI_VID_INTEL) {
+		printk(BIOS_ERR, "PTOM-dev type PCI!\n");
+		return;}

/* Retrieve the SAR limits data */
    if (get_wifi_sar_limits(&sar_limits) < 0) {
@@ -687,10 +688,13 @@
    sar_emit_ppag(sar_limits.ppag);
    sar_emit_wtas(sar_limits.wtas);
    sar_emit_wbem(sar_limits.wbem);
+	printk(BIOS_ERR, "PTOM-progressing in  getting SAR limits!\n");

/* copy the dsm data to be later used for creating _DSM function */
-	if (sar_limits.dsm != NULL)
-		memcpy(dsm, sar_limits.dsm, sizeof(struct dsm_profile));
+	if (sar_limits.dsm != NULL) {
+		printk(BIOS_ERR, "PTOM- getting SAR limits-> dsm!\n");
+		memcpy(dsm, sar_limits.dsm, sizeof(struct dsm_profile));}
+	printk(BIOS_ERR, "PTOM- !\n");

/* copy the bsar data to be later used for creating Bluetooth BRDS method */
    if (sar_limits.bsar != NULL) {
@@ -698,6 +702,10 @@
    	*bsar_loaded = true;
    }

+//	free(sar_limits.sar);
+	printk(BIOS_ERR, "PTOM- getting SAR limits-> dsm!\n");
+printk(BIOS_ERR, "PTOM-SARlimits-> dsm_reg = %d !\n",sar_limits.dsm.regulatory_configurations);
+printk(BIOS_ERR, "PTOM-SARlimits-> dsm_reg = %d !\n",sar_limits.dsm.support_ultra_high_band);
    free(sar_limits.sar);
 }

@@ -768,6 +776,8 @@
    	emit_sar_acpi_structures(dev, &dsm, &bsar, &bsar_loaded);

if (dsm.supported_functions != 0) {
+			printk(BIOS_ERR, "PTOM - not supported func\n");
+
    		for (int i = 1; i < ARRAY_SIZE(wifi_dsm_callbacks); i++)
    			if (!(dsm.supported_functions & (1 << i)))
    				wifi_dsm_callbacks[i] = NULL;