Attention is currently required from: Nico Huber, Furquan Shaikh, Tim Wawrzynczak.
Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52737 )
Change subject: libpayload: i8042: Enable keyboard translation by defualt on exit
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Another option would be to set the default to `n`, but then select it for `EC_GOOGLE_CHROMEEC`, sinc […]
Would need to just use CHROMEOS since this is inside libpayload kconfig, but that could certainly work for chrome os to keep the default for everyone else set to translation disabled.
Anyone using libpayload on a recent chromebook would also need to set this to 'n' to get a working keyboard.
I'm happy to do whatever works for upstream.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52737
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I25dfe3f425a5bb57e97476564886672b707aa3bd
Gerrit-Change-Number: 52737
Gerrit-PatchSet: 1
Gerrit-Owner: Duncan Laurie
duncan@iceblink.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Wed, 28 Apr 2021 18:04:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment