Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47381 )
Change subject: drivers/analogix: add MIPI rx flow ......................................................................
Patch Set 5:
(4 comments)
https://review.coreboot.org/c/coreboot/+/47381/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47381/5//COMMIT_MSG@9 PS5, Line 9: special Remove this.
https://review.coreboot.org/c/coreboot/+/47381/5//COMMIT_MSG@11 PS5, Line 11: became becomes
https://review.coreboot.org/c/coreboot/+/47381/5//COMMIT_MSG@11 PS5, Line 11: untill until
https://review.coreboot.org/c/coreboot/+/47381/5/src/drivers/analogix/anx762... File src/drivers/analogix/anx7625/anx7625.c:
https://review.coreboot.org/c/coreboot/+/47381/5/src/drivers/analogix/anx762... PS5, Line 821: ret = anx7625_reg_write(bus, RX_P1_ADDR, 0x0f, 0x00); : if (ret < 0) Simply
if (anx7625_reg_write(...) < 0)
Then local variable 'ret' can be removed, unless you want to print the return value like this:
ANXERROR("...%d\n", ret);