Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46438 )
Change subject: soc/intel/tigerlake: Disable C1 Cstate Demotion ......................................................................
Patch Set 1:
(6 comments)
https://review.coreboot.org/c/coreboot/+/46438/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46438/1//COMMIT_MSG@7 PS1, Line 7: Cstate C-State
https://review.coreboot.org/c/coreboot/+/46438/1//COMMIT_MSG@9 PS1, Line 9: state C-State
https://review.coreboot.org/c/coreboot/+/46438/1//COMMIT_MSG@9 PS1, Line 9: improve SoC power decrease SoC power usage
https://review.coreboot.org/c/coreboot/+/46438/1//COMMIT_MSG@12 PS1, Line 12: to C1 based on uncore auto-demote information. I wonder, what the autodemotion is useful for.
https://review.coreboot.org/c/coreboot/+/46438/1//COMMIT_MSG@16 PS1, Line 16: eg 'Google Meets video call' Please give concrete numbers, and how that was measured.
https://review.coreboot.org/c/coreboot/+/46438/1/src/soc/intel/tigerlake/fsp... File src/soc/intel/tigerlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/46438/1/src/soc/intel/tigerlake/fsp... PS1, Line 361: Cstate C-State