1 Dec
2020
1 Dec
'20
6:19 p.m.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48089 )
Change subject: intel/common/block/gpio: only reset configured SMI instead of all ......................................................................
Patch Set 10: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/48089/10/src/soc/intel/common/block... File src/soc/intel/common/block/gpio/gpio.c:
https://review.coreboot.org/c/coreboot/+/48089/10/src/soc/intel/common/block... PS10, Line 170: en_value
nit: Should this be just value since it is used for both sts_reg and en_reg?
or maybe gpio_bitmask?
--
To view, visit https://review.coreboot.org/c/coreboot/+/48089
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iecf789d3009011381835959cb1c166f703f1c0cc
Gerrit-Change-Number: 48089
Gerrit-PatchSet: 10
Gerrit-Owner: Michael Niewöhner foss@mniewoehner.de
Gerrit-Reviewer: Felix Singer felixsinger@posteo.net
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 01 Dec 2020 18:19:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Furquan Shaikh furquan@google.com
Gerrit-MessageType: comment