Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41069 )
Change subject: soc/amd/common/block/lpc: Add config options for eSPI
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41069/1/src/soc/amd/common/block/lp...
File src/soc/amd/common/block/lpc/Kconfig:
https://review.coreboot.org/c/coreboot/+/41069/1/src/soc/amd/common/block/lp...
PS1, Line 19: Select this option if mainboard uses eSPI instead of LPC (if supported
This sounds a bit like LPC and eSPI were mutually exclusive which they aren't. On Mandolin the EC is on eSPI, but I get serial output via a SIO chip on LPC
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41069
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I15e9eb25706e09393c019eea4d61b66f17490be6
Gerrit-Change-Number: 41069
Gerrit-PatchSet: 1
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 06 May 2020 13:46:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment