Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42798 )
Change subject: drivers/mrc_cache: Avoid unused variable assignment ......................................................................
Patch Set 1:
Strangely, for comparing with `BUILD_TIMELESS=1`, building the Lenovo ThinkPad X201 with `CONFIG_MRC_SETTINGS_PROTECT` selected, the object `mrc_cache.o` differs, but it’s stripped by the linker for `coreboot.rom`.
``` $ more defconfig CONFIG_VENDOR_LENOVO=y CONFIG_BOARD_LENOVO_X201=y CONFIG_NO_GFX_INIT=y CONFIG_MRC_SETTINGS_PROTECT=y CONFIG_PAYLOAD_NONE=y ```
``` $ LANG=C diff -ur build-1 build-2 Binary files build-1/cbfs/fallback/ramstage.debug and build-2/cbfs/fallback/ramstage.debug differ Binary files build-1/cbfs/fallback/romstage.debug and build-2/cbfs/fallback/romstage.debug differ Binary files build-1/cbfs/fallback/romstage.elf and build-2/cbfs/fallback/romstage.elf differ diff -ur build-1/dsdt.dsl build-2/dsdt.dsl --- build-1/dsdt.dsl 2020-06-28 09:45:38.065799763 +0200 +++ build-2/dsdt.dsl 2020-06-28 09:36:09.835617515 +0200 @@ -5,7 +5,7 @@ * * Disassembling to symbolic ASL+ operators * - * Disassembly of build/dsdt.aml, Sun Jun 28 07:45:38 2020 + * Disassembly of build/dsdt.aml, Sun Jun 28 07:36:09 2020 * * Original Table Header: * Signature "DSDT" Binary files build-1/generated/ramstage.o and build-2/generated/ramstage.o differ Only in build-1/mainboard/lenovo/x201: cbfs-file.3v1XCM Only in build-1/mainboard/lenovo/x201: cbfs-file.3v1XCM.out Only in build-2/mainboard/lenovo/x201: cbfs-file.frB3XA Only in build-2/mainboard/lenovo/x201: cbfs-file.frB3XA.out Binary files build-1/ramstage/drivers/mrc_cache/mrc_cache.o and build-2/ramstage/drivers/mrc_cache/mrc_cache.o differ Binary files build-1/ramstage/drivers/mrc_cache/ramstage.a and build-2/ramstage/drivers/mrc_cache/ramstage.a differ Binary files build-1/romstage/drivers/mrc_cache/mrc_cache.o and build-2/romstage/drivers/mrc_cache/mrc_cache.o differ ```