build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40013 )
Change subject: src/lib: Update gcov-io.[ch] (test) ......................................................................
Patch Set 1:
(536 comments)
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h File src/lib/gcov-io.h:
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@45 PS1, Line 45: int32: byte3 byte2 byte1 byte0 | byte0 byte1 byte2 byte3 code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@45 PS1, Line 45: int32: byte3 byte2 byte1 byte0 | byte0 byte1 byte2 byte3 please, no space before tabs
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@45 PS1, Line 45: int32: byte3 byte2 byte1 byte0 | byte0 byte1 byte2 byte3 please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@45 PS1, Line 45: int32: byte3 byte2 byte1 byte0 | byte0 byte1 byte2 byte3 spaces required around that ':' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@45 PS1, Line 45: int32: byte3 byte2 byte1 byte0 | byte0 byte1 byte2 byte3 labels should not be indented
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@51 PS1, Line 51: The basic format of the notes file is please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@55 PS1, Line 55: The basic format of the data file is please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@57 PS1, Line 57: file : int32:magic int32:version int32:stamp record* code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@57 PS1, Line 57: file : int32:magic int32:version int32:stamp record* please, no space before tabs
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@57 PS1, Line 57: file : int32:magic int32:version int32:stamp record* please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@70 PS1, Line 70: consists of a two character major version number please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@71 PS1, Line 71: (first digit starts from 'A' letter to not to clash with the older please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@72 PS1, Line 72: numbering scheme), the single character minor version number, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@73 PS1, Line 73: and a single character indicating the status of the release. please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@78 PS1, Line 78: incompatible with itself. For gcc 17.0 experimental, it would be please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@79 PS1, Line 79: 'B70e' (0x42373065). As we currently do not release more than 5 minor please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@80 PS1, Line 80: releases, the single character should be always fine. Major number please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@81 PS1, Line 81: is currently changed roughly every year, which gives us space please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@82 PS1, Line 82: for next 250 years (maximum allowed number would be 259.9). please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@82 PS1, Line 82: for next 250 years (maximum allowed number would be 259.9). space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@86 PS1, Line 86: record: header data code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@86 PS1, Line 86: record: header data please, no space before tabs
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@86 PS1, Line 86: record: header data please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@86 PS1, Line 86: record: header data spaces required around that ':' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@86 PS1, Line 86: record: header data labels should not be indented
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@105 PS1, Line 105: The notes file contains the following records please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@106 PS1, Line 106: note: unit function-graph* code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@106 PS1, Line 106: note: unit function-graph* please, no space before tabs
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@106 PS1, Line 106: note: unit function-graph* please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@106 PS1, Line 106: note: unit function-graph* spaces required around that ':' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@106 PS1, Line 106: note: unit function-graph* labels should not be indented
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@111 PS1, Line 111: string:name string:source int32:start_lineno int32:start_column int32:end_lineno labels should not be indented
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@115 PS1, Line 115: lines: header int32:block_no line* code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@115 PS1, Line 115: lines: header int32:block_no line* spaces required around that ':' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@115 PS1, Line 115: lines: header int32:block_no line* labels should not be indented
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@116 PS1, Line 116: int32:0 string:NULL code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@136 PS1, Line 136: data: {unit summary:object function-data*}* spaces required around that ':' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@136 PS1, Line 136: data: {unit summary:object function-data*}* space required before that '*' (ctx:VxE)
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@136 PS1, Line 136: data: {unit summary:object function-data*}* space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@136 PS1, Line 136: data: {unit summary:object function-data*}* labels should not be indented
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@143 PS1, Line 143: summary: int32:checksum int32:runs int32:sum_max spaces required around that ':' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@143 PS1, Line 143: summary: int32:checksum int32:runs int32:sum_max labels should not be indented
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@188 PS1, Line 188: typedef unsigned gcov_unsigned_t; Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@189 PS1, Line 189: typedef unsigned gcov_position_t; Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@200 PS1, Line 200: #if defined (HOST_HAS_F_SETLKW) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@217 PS1, Line 217: #define gcov_nonruntime_assert(EXPR) gcc_assert (EXPR) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@217 PS1, Line 217: #define gcov_nonruntime_assert(EXPR) gcc_assert (EXPR) Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@218 PS1, Line 218: #define gcov_error(...) fatal_error (input_location, __VA_ARGS__) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@218 PS1, Line 218: #define gcov_error(...) fatal_error (input_location, __VA_ARGS__) Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@231 PS1, Line 231: #define GCOV_VERSION ((gcov_unsigned_t)0x89abcdef) code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@231 PS1, Line 231: #define GCOV_VERSION ((gcov_unsigned_t)0x89abcdef) please, no space before tabs
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@236 PS1, Line 236: #define GCOV_UNSIGNED2STRING(ARRAY,VALUE) \ space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@237 PS1, Line 237: ((ARRAY)[0] = (char)((VALUE) >> 24), \ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@238 PS1, Line 238: (ARRAY)[1] = (char)((VALUE) >> 16), \ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@239 PS1, Line 239: (ARRAY)[2] = (char)((VALUE) >> 8), \ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@240 PS1, Line 240: (ARRAY)[3] = (char)((VALUE) >> 0)) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@255 PS1, Line 255: #define GCOV_TAG_COUNTER_BASE ((gcov_unsigned_t)0x01a10000) please, no space before tabs
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@285 PS1, Line 285: (GCOV_LAST_VALUE_COUNTER - GCOV_FIRST_VALUE_COUNTER + 1) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@298 PS1, Line 298: ((unsigned)(((TAG) - GCOV_TAG_COUNTER_BASE) >> 17)) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@301 PS1, Line 301: (!((TAG) & 0xFFFF) && GCOV_COUNTER_FOR_TAG (TAG) < GCOV_COUNTERS) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@309 PS1, Line 309: #define GCOV_TAG_IS_SUBTAG(TAG,SUB) \ space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@310 PS1, Line 310: (GCOV_TAG_MASK (TAG) >> 8 == GCOV_TAG_MASK (SUB) \ please, no space before tabs
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@310 PS1, Line 310: (GCOV_TAG_MASK (TAG) >> 8 == GCOV_TAG_MASK (SUB) \ space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@310 PS1, Line 310: (GCOV_TAG_MASK (TAG) >> 8 == GCOV_TAG_MASK (SUB) \ space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@311 PS1, Line 311: && !(((SUB) ^ (TAG)) & ~GCOV_TAG_MASK (TAG))) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@314 PS1, Line 314: #define GCOV_TAG_IS_SUBLEVEL(TAG,SUB) \ space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@315 PS1, Line 315: (GCOV_TAG_MASK (TAG) > GCOV_TAG_MASK (SUB)) code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@315 PS1, Line 315: (GCOV_TAG_MASK (TAG) > GCOV_TAG_MASK (SUB)) please, no space before tabs
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@315 PS1, Line 315: (GCOV_TAG_MASK (TAG) > GCOV_TAG_MASK (SUB)) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@315 PS1, Line 315: (GCOV_TAG_MASK (TAG) > GCOV_TAG_MASK (SUB)) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@315 PS1, Line 315: (GCOV_TAG_MASK (TAG) > GCOV_TAG_MASK (SUB)) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@321 PS1, Line 321: #define GCOV_ARC_ON_TREE (1 << 0) please, no space before tabs
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@328 PS1, Line 328: { open brace '{' following struct go on the same line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@329 PS1, Line 329: gcov_unsigned_t runs; /* Number of program runs. */ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@330 PS1, Line 330: gcov_type sum_max; /* Sum of individual run max values. */ please, no space before tabs
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@330 PS1, Line 330: gcov_type sum_max; /* Sum of individual run max values. */ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@346 PS1, Line 346: GCOV_LINKAGE int gcov_open (const char */*name*/, int /*direction*/); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@347 PS1, Line 347: GCOV_LINKAGE int gcov_magic (gcov_unsigned_t, gcov_unsigned_t); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@347 PS1, Line 347: GCOV_LINKAGE int gcov_magic (gcov_unsigned_t, gcov_unsigned_t); function definition argument 'gcov_unsigned_t' should also have an identifier name
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@347 PS1, Line 347: GCOV_LINKAGE int gcov_magic (gcov_unsigned_t, gcov_unsigned_t); function definition argument 'gcov_unsigned_t' should also have an identifier name
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@351 PS1, Line 351: GCOV_LINKAGE int gcov_close (void) ATTRIBUTE_HIDDEN; space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@353 PS1, Line 353: GCOV_LINKAGE gcov_type gcov_read_counter (void) ATTRIBUTE_HIDDEN; space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@354 PS1, Line 354: GCOV_LINKAGE void gcov_read_summary (struct gcov_summary *) ATTRIBUTE_HIDDEN; space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@355 PS1, Line 355: GCOV_LINKAGE const char *gcov_read_string (void); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@356 PS1, Line 356: GCOV_LINKAGE void gcov_sync (gcov_position_t /*base*/, space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@356 PS1, Line 356: GCOV_LINKAGE void gcov_sync (gcov_position_t /*base*/, function definition argument 'gcov_position_t' should also have an identifier name
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@356 PS1, Line 356: GCOV_LINKAGE void gcov_sync (gcov_position_t /*base*/, function definition argument 'gcov_unsigned_t' should also have an identifier name
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@358 PS1, Line 358: char *mangle_path (char const *base); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@367 PS1, Line 367: GCOV_LINKAGE void gcov_write_string (const char *); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@368 PS1, Line 368: GCOV_LINKAGE void gcov_write_filename (const char *); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@368 PS1, Line 368: GCOV_LINKAGE void gcov_write_filename (const char *); function definition argument 'const char *' should also have an identifier name
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@369 PS1, Line 369: GCOV_LINKAGE gcov_position_t gcov_write_tag (gcov_unsigned_t); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@369 PS1, Line 369: GCOV_LINKAGE gcov_position_t gcov_write_tag (gcov_unsigned_t); function definition argument 'gcov_unsigned_t' should also have an identifier name
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@370 PS1, Line 370: GCOV_LINKAGE void gcov_write_length (gcov_position_t /*position*/); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@370 PS1, Line 370: GCOV_LINKAGE void gcov_write_length (gcov_position_t /*position*/); function definition argument 'gcov_position_t' should also have an identifier name
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@375 PS1, Line 375: GCOV_LINKAGE time_t gcov_time (void); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c File src/lib/gcov-io.c:
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@31 PS1, Line 31: static void gcov_write_block (unsigned); Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@31 PS1, Line 31: static void gcov_write_block (unsigned); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@32 PS1, Line 32: static gcov_unsigned_t *gcov_write_words (unsigned); Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@32 PS1, Line 32: static gcov_unsigned_t *gcov_write_words (unsigned); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@34 PS1, Line 34: static const gcov_unsigned_t *gcov_read_words (unsigned); Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@34 PS1, Line 34: static const gcov_unsigned_t *gcov_read_words (unsigned); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@36 PS1, Line 36: static void gcov_allocate (unsigned); Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@36 PS1, Line 36: static void gcov_allocate (unsigned); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@43 PS1, Line 43: { open brace '{' following struct go on the same line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@44 PS1, Line 44: FILE *file; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@45 PS1, Line 45: gcov_position_t start; /* Position of first byte of block */ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@46 PS1, Line 46: unsigned offset; /* Read/write position within the block. */ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@46 PS1, Line 46: unsigned offset; /* Read/write position within the block. */ Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@47 PS1, Line 47: unsigned length; /* Read limit in the block. */ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@47 PS1, Line 47: unsigned length; /* Read limit in the block. */ Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@48 PS1, Line 48: unsigned overread; /* Number of words overread. */ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@48 PS1, Line 48: unsigned overread; /* Number of words overread. */ Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@49 PS1, Line 49: int error; /* < 0 overflow, > 0 disk error. */ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@50 PS1, Line 50: int mode; /* < 0 writing, > 0 reading */ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@56 PS1, Line 56: gcov_unsigned_t buffer[GCOV_BLOCK_SIZE + 1]; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@58 PS1, Line 58: int endian; /* Swap endianness. */ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@61 PS1, Line 61: size_t alloc; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@62 PS1, Line 62: gcov_unsigned_t *buffer; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@72 PS1, Line 72: gcov_position (void) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@74 PS1, Line 74: gcov_nonruntime_assert (gcov_var.mode > 0); trailing whitespace
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@74 PS1, Line 74: gcov_nonruntime_assert (gcov_var.mode > 0); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@74 PS1, Line 74: gcov_nonruntime_assert (gcov_var.mode > 0); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@75 PS1, Line 75: return gcov_var.start + gcov_var.offset; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@84 PS1, Line 84: gcov_is_error (void) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@86 PS1, Line 86: return gcov_var.file ? gcov_var.error : 1; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@92 PS1, Line 92: gcov_rewrite (void) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@94 PS1, Line 94: gcov_var.mode = -1; trailing whitespace
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@94 PS1, Line 94: gcov_var.mode = -1; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@95 PS1, Line 95: gcov_var.start = 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@96 PS1, Line 96: gcov_var.offset = 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@97 PS1, Line 97: fseek (gcov_var.file, 0L, SEEK_SET); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@97 PS1, Line 97: fseek (gcov_var.file, 0L, SEEK_SET); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@101 PS1, Line 101: static inline gcov_unsigned_t from_file (gcov_unsigned_t value) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@104 PS1, Line 104: if (gcov_var.endian) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@104 PS1, Line 104: if (gcov_var.endian) that open brace { should be on the previous line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@104 PS1, Line 104: if (gcov_var.endian) suspect code indent for conditional statements (2, 6)
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@105 PS1, Line 105: { please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@106 PS1, Line 106: value = (value >> 16) | (value << 16); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@107 PS1, Line 107: value = ((value & 0xff00ff) << 8) | ((value >> 8) & 0xff00ff); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@108 PS1, Line 108: } please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@110 PS1, Line 110: return value; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@124 PS1, Line 124: gcov_open (const char *name) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@126 PS1, Line 126: gcov_open (const char *name, int mode) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@130 PS1, Line 130: int mode = 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@133 PS1, Line 133: struct flock s_flock; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@134 PS1, Line 134: int fd; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@136 PS1, Line 136: s_flock.l_whence = SEEK_SET; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@137 PS1, Line 137: s_flock.l_start = 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@138 PS1, Line 138: s_flock.l_len = 0; /* Until EOF. */ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@139 PS1, Line 139: s_flock.l_pid = getpid (); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@139 PS1, Line 139: s_flock.l_pid = getpid (); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@142 PS1, Line 142: gcov_nonruntime_assert (!gcov_var.file); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@142 PS1, Line 142: gcov_nonruntime_assert (!gcov_var.file); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@143 PS1, Line 143: gcov_var.start = 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@144 PS1, Line 144: gcov_var.offset = gcov_var.length = 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@145 PS1, Line 145: gcov_var.overread = -1u; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@146 PS1, Line 146: gcov_var.error = 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@148 PS1, Line 148: gcov_var.endian = 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@151 PS1, Line 151: if (mode > 0) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@151 PS1, Line 151: if (mode > 0) that open brace { should be on the previous line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@151 PS1, Line 151: if (mode > 0) suspect code indent for conditional statements (2, 6)
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@152 PS1, Line 152: { please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@154 PS1, Line 154: s_flock.l_type = F_RDLCK; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@156 PS1, Line 156: fd = open (name, O_RDONLY, S_IRUSR | S_IWUSR); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@156 PS1, Line 156: fd = open (name, O_RDONLY, S_IRUSR | S_IWUSR); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@156 PS1, Line 156: fd = open (name, O_RDONLY, S_IRUSR | S_IWUSR); Symbolic permissions 'S_IRUSR | S_IWUSR' are not preferred. Consider using octal permissions '0600'.
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@157 PS1, Line 157: } please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@158 PS1, Line 158: else please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@158 PS1, Line 158: else that open brace { should be on the previous line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@158 PS1, Line 158: else suspect code indent for conditional statements (2, 7)
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@159 PS1, Line 159: { please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@161 PS1, Line 161: s_flock.l_type = F_WRLCK; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@163 PS1, Line 163: fd = open (name, O_RDWR | O_CREAT | (mode < 0 ? O_TRUNC : 0), 0666); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@163 PS1, Line 163: fd = open (name, O_RDWR | O_CREAT | (mode < 0 ? O_TRUNC : 0), 0666); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@164 PS1, Line 164: } please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@165 PS1, Line 165: if (fd < 0) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@165 PS1, Line 165: if (fd < 0) suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@166 PS1, Line 166: return 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@168 PS1, Line 168: while (fcntl (fd, F_SETLKW, &s_flock) && errno == EINTR) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@168 PS1, Line 168: while (fcntl (fd, F_SETLKW, &s_flock) && errno == EINTR) suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@168 PS1, Line 168: while (fcntl (fd, F_SETLKW, &s_flock) && errno == EINTR) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@169 PS1, Line 169: continue; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@171 PS1, Line 171: gcov_var.file = fdopen (fd, (mode > 0) ? "rb" : "r+b"); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@171 PS1, Line 171: gcov_var.file = fdopen (fd, (mode > 0) ? "rb" : "r+b"); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@173 PS1, Line 173: if (!gcov_var.file) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@173 PS1, Line 173: if (!gcov_var.file) that open brace { should be on the previous line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@173 PS1, Line 173: if (!gcov_var.file) suspect code indent for conditional statements (2, 6)
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@174 PS1, Line 174: { please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@175 PS1, Line 175: close (fd); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@175 PS1, Line 175: close (fd); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@176 PS1, Line 176: return 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@177 PS1, Line 177: } please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@179 PS1, Line 179: if (mode >= 0) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@179 PS1, Line 179: if (mode >= 0) suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@181 PS1, Line 181: gcov_var.file = fopen (name, (mode > 0) ? "rb" : "r+b"); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@181 PS1, Line 181: gcov_var.file = fopen (name, (mode > 0) ? "rb" : "r+b"); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@183 PS1, Line 183: if (gcov_var.file) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@183 PS1, Line 183: if (gcov_var.file) suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@184 PS1, Line 184: mode = 1; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@185 PS1, Line 185: else if (mode <= 0) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@185 PS1, Line 185: else if (mode <= 0) suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@187 PS1, Line 187: gcov_var.file = fopen (name, "w+b"); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@187 PS1, Line 187: gcov_var.file = fopen (name, "w+b"); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@189 PS1, Line 189: if (!gcov_var.file) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@189 PS1, Line 189: if (!gcov_var.file) suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@190 PS1, Line 190: return 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@193 PS1, Line 193: gcov_var.mode = mode ? mode : 1; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@195 PS1, Line 195: setbuf (gcov_var.file, (char *)0); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@195 PS1, Line 195: setbuf (gcov_var.file, (char *)0); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@197 PS1, Line 197: return 1; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@204 PS1, Line 204: gcov_close (void) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@206 PS1, Line 206: if (gcov_var.file) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@206 PS1, Line 206: if (gcov_var.file) that open brace { should be on the previous line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@206 PS1, Line 206: if (gcov_var.file) suspect code indent for conditional statements (2, 6)
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@207 PS1, Line 207: { please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@209 PS1, Line 209: if (gcov_var.offset && gcov_var.mode < 0) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@210 PS1, Line 210: gcov_write_block (gcov_var.offset); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@212 PS1, Line 212: fclose (gcov_var.file); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@212 PS1, Line 212: fclose (gcov_var.file); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@213 PS1, Line 213: gcov_var.file = 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@214 PS1, Line 214: gcov_var.length = 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@215 PS1, Line 215: } please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@217 PS1, Line 217: free (gcov_var.buffer); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@217 PS1, Line 217: free (gcov_var.buffer); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@218 PS1, Line 218: gcov_var.alloc = 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@219 PS1, Line 219: gcov_var.buffer = 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@221 PS1, Line 221: gcov_var.mode = 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@222 PS1, Line 222: return gcov_var.error; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@231 PS1, Line 231: gcov_magic (gcov_unsigned_t magic, gcov_unsigned_t expected) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@233 PS1, Line 233: if (magic == expected) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@233 PS1, Line 233: if (magic == expected) suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@234 PS1, Line 234: return 1; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@235 PS1, Line 235: magic = (magic >> 16) | (magic << 16); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@236 PS1, Line 236: magic = ((magic & 0xff00ff) << 8) | ((magic >> 8) & 0xff00ff); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@237 PS1, Line 237: if (magic == expected) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@237 PS1, Line 237: if (magic == expected) that open brace { should be on the previous line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@237 PS1, Line 237: if (magic == expected) suspect code indent for conditional statements (2, 6)
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@238 PS1, Line 238: { please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@239 PS1, Line 239: gcov_var.endian = 1; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@240 PS1, Line 240: return -1; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@241 PS1, Line 241: } please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@242 PS1, Line 242: return 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@248 PS1, Line 248: gcov_allocate (unsigned length) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@248 PS1, Line 248: gcov_allocate (unsigned length) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@250 PS1, Line 250: size_t new_size = gcov_var.alloc; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@252 PS1, Line 252: if (!new_size) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@252 PS1, Line 252: if (!new_size) suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@253 PS1, Line 253: new_size = GCOV_BLOCK_SIZE; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@254 PS1, Line 254: new_size += length; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@255 PS1, Line 255: new_size *= 2; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@257 PS1, Line 257: gcov_var.alloc = new_size; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@258 PS1, Line 258: gcov_var.buffer = XRESIZEVAR (gcov_unsigned_t, gcov_var.buffer, new_size << 2); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@258 PS1, Line 258: gcov_var.buffer = XRESIZEVAR (gcov_unsigned_t, gcov_var.buffer, new_size << 2); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@266 PS1, Line 266: gcov_write_block (unsigned size) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@266 PS1, Line 266: gcov_write_block (unsigned size) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@268 PS1, Line 268: if (fwrite (gcov_var.buffer, size << 2, 1, gcov_var.file) != 1) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@268 PS1, Line 268: if (fwrite (gcov_var.buffer, size << 2, 1, gcov_var.file) != 1) suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@268 PS1, Line 268: if (fwrite (gcov_var.buffer, size << 2, 1, gcov_var.file) != 1) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@269 PS1, Line 269: gcov_var.error = 1; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@270 PS1, Line 270: gcov_var.start += size; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@271 PS1, Line 271: gcov_var.offset -= size; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@278 PS1, Line 278: gcov_write_words (unsigned words) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@278 PS1, Line 278: gcov_write_words (unsigned words) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@280 PS1, Line 280: gcov_unsigned_t *result; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@282 PS1, Line 282: gcov_nonruntime_assert (gcov_var.mode < 0); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@282 PS1, Line 282: gcov_nonruntime_assert (gcov_var.mode < 0); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@284 PS1, Line 284: if (gcov_var.offset >= GCOV_BLOCK_SIZE) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@284 PS1, Line 284: if (gcov_var.offset >= GCOV_BLOCK_SIZE) that open brace { should be on the previous line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@284 PS1, Line 284: if (gcov_var.offset >= GCOV_BLOCK_SIZE) suspect code indent for conditional statements (2, 6)
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@285 PS1, Line 285: { please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@286 PS1, Line 286: gcov_write_block (GCOV_BLOCK_SIZE); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@286 PS1, Line 286: gcov_write_block (GCOV_BLOCK_SIZE); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@287 PS1, Line 287: if (gcov_var.offset) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@287 PS1, Line 287: if (gcov_var.offset) that open brace { should be on the previous line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@287 PS1, Line 287: if (gcov_var.offset) suspect code indent for conditional statements (6, 10)
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@289 PS1, Line 289: memcpy (gcov_var.buffer, gcov_var.buffer + GCOV_BLOCK_SIZE, 4); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@291 PS1, Line 291: } please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@293 PS1, Line 293: if (gcov_var.offset + words > gcov_var.alloc) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@293 PS1, Line 293: if (gcov_var.offset + words > gcov_var.alloc) suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@294 PS1, Line 294: gcov_allocate (gcov_var.offset + words); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@294 PS1, Line 294: gcov_allocate (gcov_var.offset + words); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@296 PS1, Line 296: result = &gcov_var.buffer[gcov_var.offset]; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@297 PS1, Line 297: gcov_var.offset += words; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@299 PS1, Line 299: return result; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@308 PS1, Line 308: gcov_unsigned_t *buffer = gcov_write_words (1); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@308 PS1, Line 308: gcov_unsigned_t *buffer = gcov_write_words (1); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@310 PS1, Line 310: buffer[0] = value; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@318 PS1, Line 318: gcov_write_counter (gcov_type value) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@320 PS1, Line 320: gcov_unsigned_t *buffer = gcov_write_words (2); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@320 PS1, Line 320: gcov_unsigned_t *buffer = gcov_write_words (2); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@322 PS1, Line 322: buffer[0] = (gcov_unsigned_t) value; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@323 PS1, Line 323: if (sizeof (value) > sizeof (gcov_unsigned_t)) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@323 PS1, Line 323: if (sizeof (value) > sizeof (gcov_unsigned_t)) suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@323 PS1, Line 323: if (sizeof (value) > sizeof (gcov_unsigned_t)) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@323 PS1, Line 323: if (sizeof (value) > sizeof (gcov_unsigned_t)) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@324 PS1, Line 324: buffer[1] = (gcov_unsigned_t) (value >> 32); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@325 PS1, Line 325: else please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@325 PS1, Line 325: else suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@326 PS1, Line 326: buffer[1] = 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@335 PS1, Line 335: gcov_write_string (const char *string) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@337 PS1, Line 337: unsigned length = 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@337 PS1, Line 337: unsigned length = 0; Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@338 PS1, Line 338: unsigned alloc = 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@338 PS1, Line 338: unsigned alloc = 0; Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@339 PS1, Line 339: gcov_unsigned_t *buffer; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@341 PS1, Line 341: if (string) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@341 PS1, Line 341: if (string) that open brace { should be on the previous line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@341 PS1, Line 341: if (string) suspect code indent for conditional statements (2, 6)
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@342 PS1, Line 342: { please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@343 PS1, Line 343: length = strlen (string); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@343 PS1, Line 343: length = strlen (string); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@344 PS1, Line 344: alloc = (length + 4) >> 2; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@345 PS1, Line 345: } please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@347 PS1, Line 347: buffer = gcov_write_words (1 + alloc); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@347 PS1, Line 347: buffer = gcov_write_words (1 + alloc); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@349 PS1, Line 349: buffer[0] = alloc; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@351 PS1, Line 351: if (alloc > 0) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@351 PS1, Line 351: if (alloc > 0) that open brace { should be on the previous line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@351 PS1, Line 351: if (alloc > 0) suspect code indent for conditional statements (2, 6)
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@352 PS1, Line 352: { please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@353 PS1, Line 353: buffer[alloc] = 0; /* place nul terminators. */ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@354 PS1, Line 354: memcpy (&buffer[1], string, length); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@354 PS1, Line 354: memcpy (&buffer[1], string, length); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@355 PS1, Line 355: } please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@364 PS1, Line 364: gcov_write_filename (const char *filename) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@366 PS1, Line 366: if (profile_abs_path_flag && filename && filename[0] please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@366 PS1, Line 366: if (profile_abs_path_flag && filename && filename[0] that open brace { should be on the previous line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@366 PS1, Line 366: if (profile_abs_path_flag && filename && filename[0] suspect code indent for conditional statements (2, 6)
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@367 PS1, Line 367: && !(IS_DIR_SEPARATOR (filename[0]) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@367 PS1, Line 367: && !(IS_DIR_SEPARATOR (filename[0]) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@372 PS1, Line 372: { please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@373 PS1, Line 373: char *buf = getcwd (NULL, 0); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@373 PS1, Line 373: char *buf = getcwd (NULL, 0); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@374 PS1, Line 374: if (buf != NULL && buf[0]) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@374 PS1, Line 374: if (buf != NULL && buf[0]) that open brace { should be on the previous line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@374 PS1, Line 374: if (buf != NULL && buf[0]) suspect code indent for conditional statements (6, 10)
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@376 PS1, Line 376: size_t len = strlen (buf); Statements should start on a tabstop
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@376 PS1, Line 376: size_t len = strlen (buf); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@377 PS1, Line 377: buf = (char*)xrealloc (buf, len + strlen (filename) + 2); "(foo*)" should be "(foo *)"
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@377 PS1, Line 377: buf = (char*)xrealloc (buf, len + strlen (filename) + 2); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@377 PS1, Line 377: buf = (char*)xrealloc (buf, len + strlen (filename) + 2); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@378 PS1, Line 378: if (!IS_DIR_SEPARATOR (buf[len - 1])) Statements should start on a tabstop
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@378 PS1, Line 378: if (!IS_DIR_SEPARATOR (buf[len - 1])) suspect code indent for conditional statements (10, 12)
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@378 PS1, Line 378: if (!IS_DIR_SEPARATOR (buf[len - 1])) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@379 PS1, Line 379: strcat (buf, "/"); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@380 PS1, Line 380: strcat (buf, filename); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@381 PS1, Line 381: gcov_write_string (buf); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@382 PS1, Line 382: free (buf); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@383 PS1, Line 383: return; Statements should start on a tabstop
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@385 PS1, Line 385: } please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@387 PS1, Line 387: gcov_write_string (filename); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@387 PS1, Line 387: gcov_write_string (filename); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@396 PS1, Line 396: gcov_write_tag (gcov_unsigned_t tag) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@398 PS1, Line 398: gcov_position_t result = gcov_var.start + gcov_var.offset; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@399 PS1, Line 399: gcov_unsigned_t *buffer = gcov_write_words (2); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@399 PS1, Line 399: gcov_unsigned_t *buffer = gcov_write_words (2); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@401 PS1, Line 401: buffer[0] = tag; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@402 PS1, Line 402: buffer[1] = 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@404 PS1, Line 404: return result; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@413 PS1, Line 413: gcov_write_length (gcov_position_t position) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@415 PS1, Line 415: unsigned offset; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@415 PS1, Line 415: unsigned offset; Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@416 PS1, Line 416: gcov_unsigned_t length; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@417 PS1, Line 417: gcov_unsigned_t *buffer; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@419 PS1, Line 419: gcov_nonruntime_assert (gcov_var.mode < 0); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@419 PS1, Line 419: gcov_nonruntime_assert (gcov_var.mode < 0); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@420 PS1, Line 420: gcov_nonruntime_assert (position + 2 <= gcov_var.start + gcov_var.offset); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@420 PS1, Line 420: gcov_nonruntime_assert (position + 2 <= gcov_var.start + gcov_var.offset); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@421 PS1, Line 421: gcov_nonruntime_assert (position >= gcov_var.start); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@421 PS1, Line 421: gcov_nonruntime_assert (position >= gcov_var.start); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@422 PS1, Line 422: offset = position - gcov_var.start; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@423 PS1, Line 423: length = gcov_var.offset - offset - 2; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@424 PS1, Line 424: buffer = (gcov_unsigned_t *) &gcov_var.buffer[offset]; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@425 PS1, Line 425: buffer[1] = length; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@426 PS1, Line 426: if (gcov_var.offset >= GCOV_BLOCK_SIZE) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@426 PS1, Line 426: if (gcov_var.offset >= GCOV_BLOCK_SIZE) suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@427 PS1, Line 427: gcov_write_block (gcov_var.offset); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@427 PS1, Line 427: gcov_write_block (gcov_var.offset); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@435 PS1, Line 435: gcov_write_tag_length (gcov_unsigned_t tag, gcov_unsigned_t length) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@437 PS1, Line 437: gcov_unsigned_t *buffer = gcov_write_words (2); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@437 PS1, Line 437: gcov_unsigned_t *buffer = gcov_write_words (2); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@439 PS1, Line 439: buffer[0] = tag; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@440 PS1, Line 440: buffer[1] = length; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@447 PS1, Line 447: gcov_write_summary (gcov_unsigned_t tag, const struct gcov_summary *summary) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@449 PS1, Line 449: gcov_write_tag_length (tag, GCOV_TAG_SUMMARY_LENGTH); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@449 PS1, Line 449: gcov_write_tag_length (tag, GCOV_TAG_SUMMARY_LENGTH); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@450 PS1, Line 450: gcov_write_unsigned (summary->runs); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@451 PS1, Line 451: gcov_write_unsigned (summary->sum_max); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@462 PS1, Line 462: gcov_read_words (unsigned words) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@462 PS1, Line 462: gcov_read_words (unsigned words) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@464 PS1, Line 464: const gcov_unsigned_t *result; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@465 PS1, Line 465: unsigned excess = gcov_var.length - gcov_var.offset; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@465 PS1, Line 465: unsigned excess = gcov_var.length - gcov_var.offset; Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@467 PS1, Line 467: if (gcov_var.mode <= 0) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@467 PS1, Line 467: if (gcov_var.mode <= 0) suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@468 PS1, Line 468: return NULL; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@470 PS1, Line 470: if (excess < words) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@470 PS1, Line 470: if (excess < words) that open brace { should be on the previous line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@470 PS1, Line 470: if (excess < words) suspect code indent for conditional statements (2, 6)
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@471 PS1, Line 471: { please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@472 PS1, Line 472: gcov_var.start += gcov_var.offset; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@473 PS1, Line 473: if (excess) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@473 PS1, Line 473: if (excess) that open brace { should be on the previous line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@473 PS1, Line 473: if (excess) suspect code indent for conditional statements (6, 10)
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@476 PS1, Line 476: memcpy (gcov_var.buffer, gcov_var.buffer + gcov_var.offset, 4); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@478 PS1, Line 478: memmove (gcov_var.buffer, gcov_var.buffer + gcov_var.offset, space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@482 PS1, Line 482: gcov_var.offset = 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@483 PS1, Line 483: gcov_var.length = excess; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@485 PS1, Line 485: excess = GCOV_BLOCK_SIZE; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@487 PS1, Line 487: if (gcov_var.length + words > gcov_var.alloc) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@488 PS1, Line 488: gcov_allocate (gcov_var.length + words); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@489 PS1, Line 489: excess = gcov_var.alloc - gcov_var.length; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@491 PS1, Line 491: excess = fread (gcov_var.buffer + gcov_var.length, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@491 PS1, Line 491: excess = fread (gcov_var.buffer + gcov_var.length, space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@493 PS1, Line 493: gcov_var.length += excess; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@494 PS1, Line 494: if (gcov_var.length < words) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@494 PS1, Line 494: if (gcov_var.length < words) that open brace { should be on the previous line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@494 PS1, Line 494: if (gcov_var.length < words) suspect code indent for conditional statements (6, 10)
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@498 PS1, Line 498: return 0; Statements should start on a tabstop
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@500 PS1, Line 500: } please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@501 PS1, Line 501: result = &gcov_var.buffer[gcov_var.offset]; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@502 PS1, Line 502: gcov_var.offset += words; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@503 PS1, Line 503: return result; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@512 PS1, Line 512: gcov_unsigned_t value; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@513 PS1, Line 513: const gcov_unsigned_t *buffer = gcov_read_words (1); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@513 PS1, Line 513: const gcov_unsigned_t *buffer = gcov_read_words (1); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@515 PS1, Line 515: if (!buffer) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@515 PS1, Line 515: if (!buffer) suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@516 PS1, Line 516: return 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@517 PS1, Line 517: value = from_file (buffer[0]); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@517 PS1, Line 517: value = from_file (buffer[0]); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@518 PS1, Line 518: return value; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@525 PS1, Line 525: gcov_read_counter (void) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@527 PS1, Line 527: gcov_type value; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@528 PS1, Line 528: const gcov_unsigned_t *buffer = gcov_read_words (2); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@528 PS1, Line 528: const gcov_unsigned_t *buffer = gcov_read_words (2); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@530 PS1, Line 530: if (!buffer) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@530 PS1, Line 530: if (!buffer) suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@531 PS1, Line 531: return 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@532 PS1, Line 532: value = from_file (buffer[0]); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@532 PS1, Line 532: value = from_file (buffer[0]); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@533 PS1, Line 533: if (sizeof (value) > sizeof (gcov_unsigned_t)) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@533 PS1, Line 533: if (sizeof (value) > sizeof (gcov_unsigned_t)) suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@533 PS1, Line 533: if (sizeof (value) > sizeof (gcov_unsigned_t)) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@533 PS1, Line 533: if (sizeof (value) > sizeof (gcov_unsigned_t)) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@534 PS1, Line 534: value |= ((gcov_type) from_file (buffer[1])) << 32; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@534 PS1, Line 534: value |= ((gcov_type) from_file (buffer[1])) << 32; space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@535 PS1, Line 535: else if (buffer[1]) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@535 PS1, Line 535: else if (buffer[1]) suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@536 PS1, Line 536: gcov_var.error = -1; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@538 PS1, Line 538: return value; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@545 PS1, Line 545: mangle_path (char const *base) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@549 PS1, Line 549: const char *probe; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@550 PS1, Line 550: char *buffer = (char *)xmalloc (strlen (base) + 1); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@550 PS1, Line 550: char *buffer = (char *)xmalloc (strlen (base) + 1); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@550 PS1, Line 550: char *buffer = (char *)xmalloc (strlen (base) + 1); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@551 PS1, Line 551: char *ptr = buffer; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@554 PS1, Line 554: if (base[0] && base[1] == ':') please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@554 PS1, Line 554: if (base[0] && base[1] == ':') that open brace { should be on the previous line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@554 PS1, Line 554: if (base[0] && base[1] == ':') suspect code indent for conditional statements (2, 6)
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@555 PS1, Line 555: { please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@556 PS1, Line 556: ptr[0] = base[0]; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@557 PS1, Line 557: ptr[1] = '~'; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@558 PS1, Line 558: ptr += 2; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@559 PS1, Line 559: base += 2; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@560 PS1, Line 560: } please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@562 PS1, Line 562: for (; *base; base = probe) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@562 PS1, Line 562: for (; *base; base = probe) that open brace { should be on the previous line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@562 PS1, Line 562: for (; *base; base = probe) suspect code indent for conditional statements (2, 6)
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@563 PS1, Line 563: { please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@564 PS1, Line 564: size_t len; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@566 PS1, Line 566: for (probe = base; *probe; probe++) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@567 PS1, Line 567: if (*probe == '/') suspect code indent for conditional statements (8, 10)
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@568 PS1, Line 568: break; Statements should start on a tabstop
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@569 PS1, Line 569: len = probe - base; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@570 PS1, Line 570: if (len == 2 && base[0] == '.' && base[1] == '.') please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@572 PS1, Line 572: else please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@572 PS1, Line 572: else that open brace { should be on the previous line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@572 PS1, Line 572: else suspect code indent for conditional statements (6, 10)
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@574 PS1, Line 574: memcpy (ptr, base, len); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@577 PS1, Line 577: if (*probe) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@577 PS1, Line 577: if (*probe) that open brace { should be on the previous line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@577 PS1, Line 577: if (*probe) suspect code indent for conditional statements (6, 10)
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@582 PS1, Line 582: } please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@585 PS1, Line 585: *ptr = '\0'; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@587 PS1, Line 587: return buffer; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@592 PS1, Line 592: #if !IN_LIBGCOV || defined (IN_GCOV_TOOL) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@598 PS1, Line 598: gcov_read_string (void) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@600 PS1, Line 600: unsigned length = gcov_read_unsigned (); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@600 PS1, Line 600: unsigned length = gcov_read_unsigned (); Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@602 PS1, Line 602: if (!length) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@602 PS1, Line 602: if (!length) suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@603 PS1, Line 603: return 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@605 PS1, Line 605: return (const char *) gcov_read_words (length); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@605 PS1, Line 605: return (const char *) gcov_read_words (length); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@610 PS1, Line 610: gcov_read_summary (struct gcov_summary *summary) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@612 PS1, Line 612: summary->runs = gcov_read_unsigned (); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@613 PS1, Line 613: summary->sum_max = gcov_read_unsigned (); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@618 PS1, Line 618: #if !IN_LIBGCOV || defined (IN_GCOV_TOOL) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@623 PS1, Line 623: gcov_sync (gcov_position_t base, gcov_unsigned_t length) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@625 PS1, Line 625: gcov_nonruntime_assert (gcov_var.mode > 0); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@625 PS1, Line 625: gcov_nonruntime_assert (gcov_var.mode > 0); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@626 PS1, Line 626: base += length; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@627 PS1, Line 627: if (base - gcov_var.start <= gcov_var.length) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@627 PS1, Line 627: if (base - gcov_var.start <= gcov_var.length) suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@628 PS1, Line 628: gcov_var.offset = base - gcov_var.start; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@629 PS1, Line 629: else please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@629 PS1, Line 629: else that open brace { should be on the previous line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@629 PS1, Line 629: else suspect code indent for conditional statements (2, 6)
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@630 PS1, Line 630: { please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@631 PS1, Line 631: gcov_var.offset = gcov_var.length = 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@632 PS1, Line 632: fseek (gcov_var.file, base << 2, SEEK_SET); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@632 PS1, Line 632: fseek (gcov_var.file, base << 2, SEEK_SET); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@633 PS1, Line 633: gcov_var.start = ftell (gcov_var.file) >> 2; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@633 PS1, Line 633: gcov_var.start = ftell (gcov_var.file) >> 2; space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@634 PS1, Line 634: } please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@642 PS1, Line 642: gcov_seek (gcov_position_t base) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@644 PS1, Line 644: if (gcov_var.offset) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@644 PS1, Line 644: if (gcov_var.offset) suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@645 PS1, Line 645: gcov_write_block (gcov_var.offset); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@645 PS1, Line 645: gcov_write_block (gcov_var.offset); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@646 PS1, Line 646: fseek (gcov_var.file, base << 2, SEEK_SET); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@646 PS1, Line 646: fseek (gcov_var.file, base << 2, SEEK_SET); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@647 PS1, Line 647: gcov_var.start = ftell (gcov_var.file) >> 2; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@647 PS1, Line 647: gcov_var.start = ftell (gcov_var.file) >> 2; space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@655 PS1, Line 655: gcov_time (void) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@657 PS1, Line 657: struct stat status; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@659 PS1, Line 659: if (fstat (fileno (gcov_var.file), &status)) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@659 PS1, Line 659: if (fstat (fileno (gcov_var.file), &status)) suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@659 PS1, Line 659: if (fstat (fileno (gcov_var.file), &status)) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@659 PS1, Line 659: if (fstat (fileno (gcov_var.file), &status)) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@660 PS1, Line 660: return 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@661 PS1, Line 661: else please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@661 PS1, Line 661: else suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@662 PS1, Line 662: return status.st_mtime; please, no spaces at the start of a line