Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43809 )
Change subject: mb/asus/p2b: Drop select SMP ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/43809/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43809/2//COMMIT_MSG@7 PS2, Line 7: mb/asus/p2b,emulation/qemu: Drop select SMP
I can easily ack the asus/p2b change. […]
Done
https://review.coreboot.org/c/coreboot/+/43809/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43809/3//COMMIT_MSG@11 PS3, Line 11: With MAX_CPUS==1, this has the effect of removing spinlock : implementation. But since is_smp_boot() evaluates false and : SMM uses separate smi_semaphore, there is no concurrency to : protect against with a spinlock.
My expectation was MAX_CPUS==1,SMP=n would have been identical to MAX_CPUS==1,SMP=y, but it is not. […]
Done