Attention is currently required from: Felix Singer.
Hello Felix Singer, build bot (Jenkins),
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/82759?usp=email
to review the following change.
Change subject: Revert "tree: Use Wcalloc-transposed-args command option" ......................................................................
Revert "tree: Use Wcalloc-transposed-args command option"
This reverts commit b3db3abd6311924930f3250c9f9fc3157fbbf7da.
Reason for revert: `Wcalloc-transposed-args` is new command option came with GCC-14. older versions will not support it.
Change-Id: I74ef8de1f7d38e1e0519c3b41e79fd9b11d8e16f --- M Makefile.mk M src/southbridge/intel/common/rcba_pirq.c 2 files changed, 1 insertion(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/82759/1
diff --git a/Makefile.mk b/Makefile.mk index e406702..0358c88 100644 --- a/Makefile.mk +++ b/Makefile.mk @@ -502,7 +502,6 @@ CFLAGS_common += -Wstring-compare ifeq ($(CONFIG_COMPILER_GCC),y) CFLAGS_common += -Wold-style-declaration -Wflex-array-member-not-at-end -CFLAGS_common += -Wcalloc-transposed-args # Don't add these GCC specific flags when running scan-build ifeq ($(CCC_ANALYZER_OUTPUT_FORMAT),) CFLAGS_common += -Wno-packed-not-aligned diff --git a/src/southbridge/intel/common/rcba_pirq.c b/src/southbridge/intel/common/rcba_pirq.c index ce44bc4..c9f1518 100644 --- a/src/southbridge/intel/common/rcba_pirq.c +++ b/src/southbridge/intel/common/rcba_pirq.c @@ -58,7 +58,7 @@
printk(BIOS_DEBUG, "Generating ACPI PIRQ entries\n");
- pin_irq_map = calloc(MAX_SLOTS * PCI_INT_MAX, sizeof(struct slot_pin_irq_map)); + pin_irq_map = calloc(sizeof(struct slot_pin_irq_map), MAX_SLOTS * PCI_INT_MAX); pirq_map.type = PIRQ_SOURCE_PATH; for (i = 0; i < PIRQ_COUNT; i++) snprintf(pirq_map.source_path[i], sizeof(pirq_map.source_path[i]),