Attention is currently required from: Martin L Roth, Angel Pons, Julius Werner.
Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67918 )
Change subject: tests: Add option for debug symbols & no optimization
......................................................................
Patch Set 3:
(2 comments)
File tests/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/67918/comment/32c6f3ad_79f61939
PS2, Line 183: GDB_DEBUG=y
Done. […]
I think it's good solution for now.
I have to check tests build-system and fix all these variables some time. :)
File tests/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/67918/comment/870815b3_4fbd1956
PS3, Line 13: # Enable GDB debug build if requested
: GDB_DEBUG?=0
1. unnecessary space at lines start
2. add space around assign operator
--
To view, visit
https://review.coreboot.org/c/coreboot/+/67918
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3a644dcccb7e15473413b775da8f70617afaefce
Gerrit-Change-Number: 67918
Gerrit-PatchSet: 3
Gerrit-Owner: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Mon, 31 Oct 2022 07:49:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin L Roth
gaumless@gmail.com
Comment-In-Reply-To: Jakub Czapiga
jacz@semihalf.com
Gerrit-MessageType: comment